Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons missing on the editor tabbar when opening a file from the SCM view #7947

Closed
lmcbout opened this issue Jun 3, 2020 · 4 comments
Closed
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help scm issues related to the source control manager vscode issues related to VSCode compatibility

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Jun 3, 2020

Bug Description:

Using GIt-UI and GIT plugins version 1.39.1, there are some commands missing on the editor tabbar. The icons are not present as they are on VSCODE.

On the editor tab, the missings icons are when the file is open in a single editor

- Open changes With Previous revision
- Show Revision details
- Open Changes with Next Revision
- Toggle File Blame annotation 
- More actions

When the editor is showing the diff editor, then other icons are added

- Open File (Alternate with the "Open Changes"
- Previous changes
- Next changes
- Show leading/Trailing Whitespace Differences

Steps to Reproduce:

  1. Open the Source control View (Git)
  2. Select a modified file in the list
    --> This open the file in diff editor
    -> Observe the icons missing to navigate/execute commands in the editor tabbar
    --> Compare with the icons in VSCODE

Additional Information

  • Operating System: Tested on Ubuntu 18.04, but is probably missing on all platforms
  • Theia Version: Latest
  • GIt /Git-UI version 1.39.1

Theia icons on the editor tabbar
TheiaIcons

VSCode icon on the tabbar
VSCodeIcons

@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help scm issues related to the source control manager vscode issues related to VSCode compatibility labels Jun 3, 2020
@akosyakov
Copy link
Member

Just to clarify VS Code was tested with git 1.39.1 extension as well? It could be that this extension is simply out-dated?

@lmcbout
Copy link
Contributor Author

lmcbout commented Jun 3, 2020

In Theia, git version 1.44.2 from ope-vsx registry does not work right now. On VSCode, this is a different version . This is why I mentioned the version I discovered this issue. When we will be able to upgrade , may be this issue might be gone !

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jun 3, 2020

@lmcbout the icons you see in vscode come from gitlens not the builtin.
You can test in vscode by running the command Reload with Extensions Disabled:

Screenshot from 2020-06-03 09-29-24

I see you've included gitlens in your vscode instance, when removed you'll see that the icons are the same.

@lmcbout
Copy link
Contributor Author

lmcbout commented Jun 3, 2020

Sorry, @vince-fugnitto found the icons comes from GITLens. Tested it and the icons are available.

@lmcbout lmcbout closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

3 participants