Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferences: use custom context-menu for browser target #7744

Closed
vince-fugnitto opened this issue May 5, 2020 · 2 comments
Closed

preferences: use custom context-menu for browser target #7744

vince-fugnitto opened this issue May 5, 2020 · 2 comments
Labels
menus issues related to the menu preferences issues related to preferences

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

Following #7105, the context-menu from the preferences-widget incorrectly uses the native menu when in the browser. This is correct for electron, but in the browser we should use the custom context-menu like the rest of the application:

Browser:

Screen Shot 2020-05-05 at 9 33 11 AM
@colin-grant-work
Copy link
Contributor

@vince-fugnitto , could you give a little more information here? Late in the process, we switched from using Phosphor's Menu directly to using Theia's ContextMenuRenderer - is this related to that change?

@vince-fugnitto
Copy link
Member Author

@vince-fugnitto , could you give a little more information here? Late in the process, we switched from using Phosphor's Menu directly to using Theia's ContextMenuRenderer - is this related to that change?

@colin-grant-work I'm sorry, I made the mistake of thinking the dropdown was a context-menu, the fact that dropdowns are native in the browser is an issue across the framework: #4673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
menus issues related to the menu preferences issues related to preferences
Projects
None yet
Development

No branches or pull requests

2 participants