[core][commands][quality] Ensure error reporting does not throw error

[kittaakos]

Bug Description:

This is a cosmetic issue. If I commit a programmer error, and I mess up something with my commands and their handlers, I want to see a clear error about the problem, this happens usually, but not always. I can hit an Uncaught (in promise) TypeError: Converting circular structure to JSON error.

command.ts:298 Uncaught (in promise) TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'TheiaDockPanel'
    |     property '_layout' -> object with constructor 'DockLayout'
    --- property '_parent' closes the circle
    at JSON.stringify (<anonymous>)
    at CommandRegistry.<anonymous> (command.ts:298)
    at step (command.ts:15)
    at Object.next (command.ts:15)
    at command.ts:15
    at new Promise (<anonymous>)
    at ../../packages/core/lib/common/command.js.__awaiter (command.ts:15)
    at CommandRegistry.../../packages/core/lib/common/command.js.CommandRegistry.executeCommand (command.ts:290)
    at TabBarToolbar._this.executeCommand (tab-bar-toolbar.tsx:184)
    at HTMLUnknownElement.callCallback (react-dom.development.js:336)

Related code:

theia/packages/core/src/common/command.ts

Line 298 in 87677a2

const argsMessage = args && args.length > 0 ? ` (args: ${JSON.stringify(args)})` : '';

Steps to Reproduce:

1. I do not know exactly. Try to execute a command without a handler and pass in a class instance. I am not sure though.

---

Help wanted: Maybe one can rebind the default JSON.stringify with a lib that handles it gracefully; for instance json-stringify-safe or a better one.

Additional Information

• Operating System:
• Theia Version:

[colin-grant-work]

Closed via #8978