Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No menu items available in Selection menu #731

Closed
lmcbout opened this issue Oct 24, 2017 · 10 comments
Closed

No menu items available in Selection menu #731

lmcbout opened this issue Oct 24, 2017 · 10 comments

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Oct 24, 2017

Menu "Selection" available, but all options are greyed out. Should we have this menu option available?
peek 2017-10-23 selectionmenu

Some discussion took place for issue in yangster:
ref: theia-ide/yangster#26

  • Most of these don't make sense for the diagram. Which ones would you like to use?
    I don't think that Theia can deactivate entire menus.

-If we use the diagram display and if none of the menu items apply to any diagram, then the menu "Selection" should not clutter the menu bar, it should be invisible when the user is editing/viewing a diagram

@kittaakos
Copy link
Contributor

kittaakos commented Oct 26, 2017

I would rephrase this: do we want to dynamically update (hide) a particular sub-menu from the main menu if none of the corresponding commands have an active handler?

I believe one has to also keep in mind whether we show an inactive menu item, or we simply omit it when no active handlers are available for the command.

Also related: #446.

@svenefftinge
Copy link
Contributor

I think the behavior is fine, since removing and adding menus based on context would be bad (as we learned in Eclipse).
I'd like to close this. Objections?

@kittaakos
Copy link
Contributor

I'd like to close this.

+1

@lmcbout
Copy link
Contributor Author

lmcbout commented Oct 30, 2017

Personally, I find it weird having a pull-down menu with no items selectable. Second, The selection menu is also completely empty when starting Theia, if you click on it, a few pixels shows the menu is selected, but nothing else, no menus. Another example. When running yangster, menu items in the "Edit" sub-menu are not needed ("Cut/COPY/PASTE") If there is no plan to make them available, why do we display them when the user is only handling some UI display?

@hexa00
Copy link

hexa00 commented Oct 30, 2017

If we don't change the menus based on context we should fix the display when there's no items... like adding a empty menu item?

@svenefftinge
Copy link
Contributor

svenefftinge commented Oct 30, 2017

The totally empty main menu (#751) is a bug. I created #760.

@svenefftinge
Copy link
Contributor

When running yangster, menu items in the "Edit" sub-menu are not needed ("Cut/COPY/PASTE") If there is no plan to make them available, why do we display them when the user is only handling some UI display?

I don't understand, could you explain what you mean?

@lmcbout
Copy link
Contributor Author

lmcbout commented Oct 30, 2017

If you look at the yangster issue:
theia-ide/yangster#29
There seems to be no plan to edit directly into the diagram. Under the "Edit" menu, there are some options to modify the editor : Copy/CUT/PASTE. If there is no plan to use those features, why are they there !!

@svenefftinge
Copy link
Contributor

Copy/Cut/Paste is supported in yangster, generally, just not in the diagram.

@svenefftinge
Copy link
Contributor

Can this ticket be closed, or is there anything we should take action on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants