-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No menu items available in Selection menu #731
Comments
I would rephrase this: do we want to dynamically update (hide) a particular sub-menu from the main menu if none of the corresponding commands have an active handler? I believe one has to also keep in mind whether we show an inactive menu item, or we simply omit it when no active handlers are available for the command. Also related: #446. |
I think the behavior is fine, since removing and adding menus based on context would be bad (as we learned in Eclipse). |
+1 |
Personally, I find it weird having a pull-down menu with no items selectable. Second, The selection menu is also completely empty when starting Theia, if you click on it, a few pixels shows the menu is selected, but nothing else, no menus. Another example. When running yangster, menu items in the "Edit" sub-menu are not needed ("Cut/COPY/PASTE") If there is no plan to make them available, why do we display them when the user is only handling some UI display? |
If we don't change the menus based on context we should fix the display when there's no items... like adding a empty menu item? |
I don't understand, could you explain what you mean? |
If you look at the yangster issue: |
Copy/Cut/Paste is supported in yangster, generally, just not in the diagram. |
Can this ticket be closed, or is there anything we should take action on? |
Menu "Selection" available, but all options are greyed out. Should we have this menu option available?
Some discussion took place for issue in yangster:
ref: theia-ide/yangster#26
I don't think that Theia can deactivate entire menus.
-If we use the diagram display and if none of the menu items apply to any diagram, then the menu "Selection" should not clutter the menu bar, it should be invisible when the user is editing/viewing a diagram
The text was updated successfully, but these errors were encountered: