Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preview: 'open preview' does not work for editor-previews #7078

Closed
lmcbout opened this issue Feb 4, 2020 · 1 comment · Fixed by #9518
Closed

preview: 'open preview' does not work for editor-previews #7078

lmcbout opened this issue Feb 4, 2020 · 1 comment · Fixed by #9518
Labels
bug bugs found in the application editor-preview issues that are related to the editor-preview help wanted issues meant to be picked up, require help

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Feb 4, 2020

Description

Preview view not showing data in electron

Reproduction Steps

Open a README.md file in electron
Open The same README.md with the preview view in electron
--> The data is not showing in the preview view

Open the same README.md file from VSCode with the preview view
--> The data shows in the preview editor view

OS and Theia version:
OS: Ubuntu 18.04
Theia: latest commit cc0da4e

Diagnostics:

Theia electron:
ElectronNotShowingPreview

VSCode preview view:
VSCodeShowPreview
@vince-fugnitto
Copy link
Member

Possibly a duplicate of #3579?
Such commands are not present or work correctly for editor-preview editors.

@vince-fugnitto vince-fugnitto added editor-preview issues that are related to the editor-preview bug bugs found in the application electron issues related to the electron target labels Feb 4, 2020
@vince-fugnitto vince-fugnitto changed the title [electron] Preview view not showing data when using electron preview: 'open preview' does not work for editor-previews Mar 30, 2020
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help and removed electron issues related to the electron target labels Mar 30, 2020
@colin-grant-work colin-grant-work mentioned this issue May 25, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application editor-preview issues that are related to the editor-preview help wanted issues meant to be picked up, require help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite editor-preview package as extensions of editor classes colin-grant-work/theia
2 participants
@lmcbout @vince-fugnitto