Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scm] align scm state markers in the explorer with VS Code #6904

Closed
azatsarynnyy opened this issue Jan 17, 2020 · 6 comments · Fixed by #9473
Closed

[scm] align scm state markers in the explorer with VS Code #6904

azatsarynnyy opened this issue Jan 17, 2020 · 6 comments · Fixed by #9473
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git good first issue good first issues for new contributors navigator issues related to the navigator/explorer scm issues related to the source control manager

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Jan 17, 2020

To align Git state markers in the Navigator with VS Code we can:

  • replace the letters on folders with the dot/circle sign indicating that files inside are modified. It looks more clear and less noisy in VS Code
  • if it's possible, apply the different color styles to the file names depending on the Git status
@azatsarynnyy azatsarynnyy added good first issue good first issues for new contributors git issues related to git labels Jan 17, 2020
@azatsarynnyy
Copy link
Member Author

Theia
image

VS Code
image

@vince-fugnitto
Copy link
Member

Moving forward, it should work when using git and git-ui builtins.
The changes are actually from scm.

@vince-fugnitto vince-fugnitto changed the title Align Git state markers in the Navigator with VS Code [scm] align scm state markers in the explorer with VS Code Jan 17, 2020
@vince-fugnitto vince-fugnitto added navigator issues related to the navigator/explorer scm issues related to the source control manager labels Jan 17, 2020
@azatsarynnyy azatsarynnyy added the enhancement issues that are enhancements to current functionality - nice to haves label Jan 17, 2020
@nisarhassan12
Copy link
Contributor

I would like to make a Pr for this.

@nisarhassan12
Copy link
Contributor

I'm not able to figure out what files to change or how to go about it. Would be nice if someone is to outline things to do in order to make it work 🙂 ?

@vince-fugnitto
Copy link
Member

I'm not able to figure out what files to change or how to go about it. Would be nice if someone is to outline things to do in order to make it work ?

This should help to get started:

protected toDecorator(change: DecorationData): TreeDecoration.Data {
const colorVariable = change.color && this.colors.toCssVariableName(change.color.id);
return {
tailDecorations: [
{
data: change.letter ? change.letter : '',
fontData: {
color: colorVariable && `var(${colorVariable})`
},
tooltip: change.title ? change.title : ''
}
]
};
}

@abdo944

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git good first issue good first issues for new contributors navigator issues related to the navigator/explorer scm issues related to the source control manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants