support "presentation" in task config

[elaihau]

Description

The way Theia organizes the output of tasks could be controlled by adding the support of "presentation":

https://code.visualstudio.com/docs/editor/tasks#_output-behavior

Reproduction Steps

• Open the tasks.json of the workspace, and add a task config.

Expected: Users can add the "presentation" object to the config to control the way that the output is presented.
Reality: "presentation" is not supported

OS and Theia version:

Ubuntu 18.04. Example browser.
Version b87052c

[elaihau]

This one covers the feature described in #5332

[elaihau]

I am currently working on presentation.panel, trying to reuse terminal widget(s) across tasks. This is most recent progress I made:

Next step is finishing up the "widget manager", and testing how well / bad this change works with the existing features in Theia.

[akosyakov]

Next step is finishing up the "widget manager"

What does it mean? :)

[elaihau]

Next step is finishing up the "widget manager"

What does it mean? :)

Sorry for the confusion. I should have said "terminal widget manager".
My idea is having a manager class to decide if a new terminal widget needs to be created. @akosyakov

[akosyakov]

ok, so something like editor manager based on widget open handler?

[elaihau]

@akosyakov thank you for sharing the insight with me.

yep, similar. but i guess at this point i don't have to extend NavigatableWidgetOpenHandler as i don't need as many features. It could be as simple as a class with only one public method getOrCreateTerminalWidget().

Also, this "terminal widget manager" will be placed inside the "task" extension, as it would only be used by tasks.

[akosyakov]

yep, similar. but i guess at this point i don't have to extend NavigatableWidgetOpenHandler as i don't need as many features. It could be as simple as a class with only one public method getOrCreateTerminalWidget().

I thought just about WidgetOpenHandler to reuse implementation of open method.

Also, this "terminal widget manager" will be placed inside the "task" extension, as it would only be used by tasks.

We should name it differently then, TerminalManager should leave in the terminal extension. We actually already have it, it is called TerminalService.

[elaihau]

Now we support echo, reveal, focus, panel, showReuseMessage, and clear. am i missing anything for this ticket ?
@vince-fugnitto @RomanNikitenko @akosyakov

[a1994846931931]

@elaihau

Hi, reuse terminal widget sounds fantastic and I'm really looking forward to the feature coming out. May I ask how's your progress?

Update: I just found out that this feature is already merged into master. Clearly my local repository is far behind master. But nevertheless, l found it behave oddly. See below:

It doesn't act as I expected:

1. the task failed;
2. the label of the task terminal seems not correct;
3. the terminal can not be reused.

Did I does something wrong? FYI, the backend shows the following error:

[elaihau]

Update: I just found out that this feature is already merged into master. Clearly my local repository is far behind master. But nevertheless, l found it behave oddly. See below:

It doesn't act as I expected:

1. the task failed;
2. the label of the task terminal seems not correct;
3. the terminal can not be reused.

@a1994846931931
As per your GIF, what you task did was echo Hello.

I guess the error you saw was due to #2961

In your task config, could you please add a sleep 1 before running echo hello, and check if it works ?

[a1994846931931]

Update: I just found out that this feature is already merged into master. Clearly my local repository is far behind master. But nevertheless, l found it behave oddly. See below:

It doesn't act as I expected:

1. the task failed;
2. the label of the task terminal seems not correct;
3. the terminal can not be reused.

@a1994846931931
As per your GIF, what you task did was echo Hello.

I guess the error you saw was due to #2961

In your task config, could you please add a sleep 1 before running echo hello, and check if it works ?

@elaihau
No, it doesn't work. It seems that the command sleep 1 is not executed at all for it returns so quickly.

Actually I've also encountered #2961 before, but they look different.

[vince-fugnitto]

No, it doesn't work. It seems that the command sleep 1 is not executed at all for it returns so quickly.

@a1994846931931 do you mind sharing your tasks.json?
You might also want to check what a bash error code of 127 means as it might help you with your problem.

[elaihau]

@elaihau
No, it doesn't work. It seems that the command sleep 1 is not executed at all for it returns so quickly.
Actually I've also encountered #2961 before, but they look different.

I tried running your task in my env and it worked:

maybe i missed some details ...

[RomanNikitenko]

@a1994846931931
I tried your configuration and it works well for me

But it's interesting to know what's the problem...

[a1994846931931]

@vince-fugnitto @elaihau @RomanNikitenko Hi, I just found out that the issue has something to do with the shell I use - zsh. It worked fine after I shifted back to bash.

[elaihau]

If there are no objections I will close this ticket in a day.