Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete terminal(pseudoTerminal) api #6589

Closed
AndrienkoAleksandr opened this issue Nov 20, 2019 · 6 comments
Closed

Complete terminal(pseudoTerminal) api #6589

AndrienkoAleksandr opened this issue Nov 20, 2019 · 6 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@AndrienkoAleksandr
Copy link
Contributor

Description

VSCode has new pseudo-terminal api https://github.com/microsoft/vscode/blob/master/src/vs/vscode.d.ts#L7518

We need implement it.

OS and Theia version:

Diagnostics:

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility labels Nov 20, 2019
@akosyakov
Copy link
Member

Are there known VS Code samples, extensions to test again?

@AndrienkoAleksandr
Copy link
Contributor Author

Are there known VS Code samples, extensions to test again?

I will take a look.

@PEZ
Copy link

PEZ commented May 25, 2020

I am about to switch to this for Calva (a Clojure extension for VS Code). Here's the PR: BetterThanTomorrow/calva#654

It's a bit ironic, because the reason I started with it was to see if it would help Calva start working in Theia. Something that is partly do to Theia loosing track of the terminal used for hosting the orphaned Task I am currently using.

I elaborated some more on how I use the API here: https://community.theia-ide.org/t/can-i-use-vscode-extensionterminal-in-theia/24

Also throwing in some more of my struggles here: https://community.gitpod.io/t/is-there-an-easy-way-to-debug-a-vscode-extension-inside-gitpod/596/68?u=pez (I wanted to keep reporting in that thread, but am to new to the community to be allowed to 😄 ).

@akosyakov
Copy link
Member

@PEZ I don't think anyone is looking into it, right now. PRs are welcomed.

@datou0412
Copy link
Contributor

this sample can be used to test extension-terminal-sample

@tsmaeder
Copy link
Contributor

Closing in favor of #12074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

5 participants