-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tslint rule to enforce project organization #5873
Comments
I think it'd be good, I don't see however a rule that can accomplish it so it'd most likely need to be a custom rule. |
vscode guys seems to have such rules: https://github.com/microsoft/vscode/blob/5cad6c4879e40eb6212ea6df8d8e024958566221/tslint.json#L38-L602 Maybe we can copy and use them. Again need a CQ 🙈 |
I guess we will need a CQ then 🙈 |
@vince-fugnitto Do you think you can have a look into it? or you busy with something else? |
I'd like to resolve my existing task PR first then I can take a look into it for you :) |
All code should be aligned with: https://github.com/theia-ide/theia/wiki/Code-Organization. It is critical since avoiding it increases amount of code which should be loaded and bundled. But it is very tedious to check import each time and new contributors very often miss it.
Maybe there is configurable tslin rule to check such things. Or we can write one based on regex.
cc @vince-fugnitto @marcdumais-work
The text was updated successfully, but these errors were encountered: