Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslint rule to enforce project organization #5873

Closed
akosyakov opened this issue Aug 6, 2019 · 5 comments · Fixed by #10124
Closed

tslint rule to enforce project organization #5873

akosyakov opened this issue Aug 6, 2019 · 5 comments · Fixed by #10124
Labels
quality issues related to code and application quality

Comments

@akosyakov
Copy link
Member

All code should be aligned with: https://github.com/theia-ide/theia/wiki/Code-Organization. It is critical since avoiding it increases amount of code which should be loaded and bundled. But it is very tedious to check import each time and new contributors very often miss it.

Maybe there is configurable tslin rule to check such things. Or we can write one based on regex.

cc @vince-fugnitto @marcdumais-work

@vince-fugnitto
Copy link
Member

I think it'd be good, I don't see however a rule that can accomplish it so it'd most likely need to be a custom rule.

@akosyakov akosyakov added the quality issues related to code and application quality label Aug 6, 2019
@akosyakov
Copy link
Member Author

vscode guys seems to have such rules: https://github.com/microsoft/vscode/blob/5cad6c4879e40eb6212ea6df8d8e024958566221/tslint.json#L38-L602

Maybe we can copy and use them. Again need a CQ 🙈

@vince-fugnitto
Copy link
Member

Maybe we can copy and use them. Again need a CQ

I guess we will need a CQ then 🙈

@akosyakov
Copy link
Member Author

@vince-fugnitto Do you think you can have a look into it? or you busy with something else?

@vince-fugnitto
Copy link
Member

@vince-fugnitto Do you think you can have a look into it? or you busy with something else?

I'd like to resolve my existing task PR first then I can take a look into it for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
2 participants