[vscode] QuickPick.selectedItems is always undefined

[tetchel]

Here's some sample code for a basic QuickPick created using window.createQuickPick

    const selected = await new Promise<readonly vscode.QuickPickItem[] | undefined>((resolve) => {
        qp.show();
        qp.onDidHide((_e) => {
            Log.d("Did hide", qp.selectedItems);
            resolve(undefined);
        });
        qp.onDidAccept((_e) => {
            Log.d("Did accept selected", qp.selectedItems);
            resolve(qp.selectedItems);
        });
        qp.onDidChangeSelection((selected_) => {
            Log.d("Did change selection", qp.selectedItems);
            Log.d("NOW SELECTED:", selected_);
        });
    })
    .finally(() => qp.dispose());

In VS Code, when the user selects an item with click / enter, the onDidAccept callback is fired and I resolve with qp.selectedItems. But in Theia, this doesn't work because selectedItems is always undefined. There is no error message in the logs.

I can work around this because the callback for onDidChangeSelection does work in Theia (ie selected_ contains the correct result), but I wanted to make an issue for this missing API.

[akosyakov]

@tetchel Could you test whether it was addressed with this PR #5187? please comment there

[akosyakov]

@tetchel Is it still valid?

[tetchel]

Yes, still a bug