-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Consume che-ls-jdt as jdt.ls extension #2849
Comments
We'd have to include the bundles from che-ls-jdt into our theia-java plugin https://github.com/eclipse/che-theia-java-plugin and to go back to using the basic jdt.ls in Theia proper. |
Related: eclipse-jdtls/eclipse.jdt.ls#746 |
@kittaakos I don't see the connection to that jdt.ls issue. |
OK then. Just keep in mind, Theia is shipped with a fork of the JDT LS: |
I guess you wanted the feature before the gitpod.io launch? But frankly, shipping with forks because you can't get your PR's and/or CQ's approved is not a good practice, IMO. |
Once we have merged Support RedHat JDT LS extensions #1878 , it would make sense to consume che-ls-jdt (as well as the microsoft java debug adapter) as extension to jdt.ls instead of using an augmented build.
The text was updated successfully, but these errors were encountered: