Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Consume che-ls-jdt as jdt.ls extension #2849

Closed
tsmaeder opened this issue Sep 11, 2018 · 5 comments
Closed

Java: Consume che-ls-jdt as jdt.ls extension #2849

tsmaeder opened this issue Sep 11, 2018 · 5 comments
Labels
debug issues that related to debug functionality java issues related to the java language todo larger scoped issues

Comments

@tsmaeder
Copy link
Contributor

Once we have merged Support RedHat JDT LS extensions #1878 , it would make sense to consume che-ls-jdt (as well as the microsoft java debug adapter) as extension to jdt.ls instead of using an augmented build.

@tsmaeder tsmaeder added java issues related to the java language todo larger scoped issues debug issues that related to debug functionality labels Sep 11, 2018
@tsmaeder
Copy link
Contributor Author

We'd have to include the bundles from che-ls-jdt into our theia-java plugin https://github.com/eclipse/che-theia-java-plugin and to go back to using the basic jdt.ls in Theia proper.

@kittaakos
Copy link
Contributor

go back to using the basic jdt.ls in Theia proper.

Related: eclipse-jdtls/eclipse.jdt.ls#746

@tsmaeder
Copy link
Contributor Author

@kittaakos I don't see the connection to that jdt.ls issue.

@kittaakos
Copy link
Contributor

OK then. Just keep in mind, Theia is shipped with a fork of the JDT LS:
https://github.com/theia-ide/theia/blob/fd9dfcaa30e77787d35fc63602baacd3fcf8ffda/packages/java/package.json#L61

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Sep 27, 2018

OK then. Just keep in mind, Theia is shipped with a fork of the JDT LS:

I guess you wanted the feature before the gitpod.io launch? But frankly, shipping with forks because you can't get your PR's and/or CQ's approved is not a good practice, IMO.
And frankly, I think it's against Eclipse foundation rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality java issues related to the java language todo larger scoped issues
Projects
None yet
Development

No branches or pull requests

2 participants