Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should hide/disable menu items applicable to workspaces when no workspace is present #2287

Closed
vince-fugnitto opened this issue Jul 5, 2018 · 2 comments

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jul 5, 2018

General issue with Theia to hide/disable menu items which are in the context of a workspace when no workspace is currently present.

Menu items such as:

  • File > Open Workspace Preferences
  • File > Save
  • File > Save All
  • Edit > Cut
  • Edit > Copy
  • Edit > Paste
  • Edit > Search in Workspace
  • etc.

do not have meaning or value when no workspace is present, and thus should be hidden or disabled to avoid confusion.

@akosyakov
Copy link
Member

a dup of #446?

@kittaakos
Copy link
Contributor

a dup of #446?

Sort of, for sure we cannot do much with the Electron application menu this point. But we have some glitches in the browser-based application too, I have just tried it. For instance, w/o a workspace we should not enable Search in Workspace.

screen shot 2018-07-06 at 08 18 56
screen shot 2018-07-06 at 08 18 50

Also; Save, Save All and Open Workspace Preferences should be disabled too.
But I disagree with Cut/Copy/Paste; one can open a terminal w/o a WS and use these commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants