Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] cannot use the 'paste' menu item in the browser application #2171

Open
lmcbout opened this issue Jun 22, 2018 · 2 comments
Open

[browser] cannot use the 'paste' menu item in the browser application #2171

lmcbout opened this issue Jun 22, 2018 · 2 comments
Labels
clipboard issues related to the clipboard enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Jun 22, 2018

Copy & Paste
1- Why don't we have those two options in the context menu of the editor ?
2- In the top menu bar of Theia, Copy / Paste are available, but no key accelerator for the Paste
3- After doing of some code copy, we cannot use the "Paste" from the top menu, a dialog says to use the browser paste or shortcut, --> Paste from Theia menu does not work
We should be able to trigger the PASTE from the browser when selecting the Paste option from Theia
Compare to eclipse editor, "Copy" and "Paste" are available form the menu, context menu in the editor and have accelerator for it.

@vince-fugnitto
Copy link
Member

  1. Why don't we have those two options in the context menu of the editor ?

The cut, copy and paste options are present in the context menu of the editor as of #2633


  1. In the top menu bar of Theia, Copy / Paste are available, but no key accelerator for the Paste

We only register the keybinding for copy and paste if the target supports it.
For the browser, the paste action is not supported so we do not see the accelerator for it, however since the electron target does support it the accelerator is present.

Screen Shot 2019-07-12 at 10 00 49 PM


3- After doing of some code copy, we cannot use the "Paste" from the top menu, a dialog says to use the browser paste or shortcut, --> Paste from Theia menu does not work

The paste action is unsupported if "The 'paste' command return false not only if the feature is unavailable, but also if the script calling it has insufficient privileges to perform the action"


Compare to eclipse editor, "Copy" and "Paste" are available form the menu, context menu in the editor and have accelerator for it.

This isn't a fair comparison, eclipse is a native desktop ide. If we compare our electron instance to eclipse they both support copy and paste.

@vince-fugnitto vince-fugnitto changed the title Paste from Theia menubar does not copy the selection [browser] cannot use the 'paste' menu item in the browser application Jul 13, 2019
@vince-fugnitto vince-fugnitto added the enhancement issues that are enhancements to current functionality - nice to haves label Jul 13, 2019
@akosyakov
Copy link
Member

There is a PR introducing core clipboard API with checking and granting privileges: #5527 We should look into improving and landing it. In the scope of it we can look whether existing clipboard actions can be rewritten in the better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clipboard issues related to the clipboard enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help
Projects
None yet
Development

No branches or pull requests

3 participants