-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of large files #1470
Comments
This also should be a good step towards collaborative editing and a sandboxed extension system like VS Code's. |
Before we go down that road, which will change some important parts in the architecture, we would like to try improving the protocol in the fs, to work with incremental changes. The idea is that we
|
I don't think it is feasible anymore after #7908 We will need to open an issue in VS Code to apply such improvements there first. |
Currently, we keep the document buffers on the client and send the full file contents back and forth on save and some other operations (LSP). This is, of course, a bit naive and needs improvements.
I propose that we move the resources and documents to the backend, such that the communication between the monaco model and the backend documents will go through text edits and versioned documents. The contents only should need to be transferred once, when opening an editor. Fetching contents could be done through a regular GET, such that we don't need to wrap large files in JSON objects, hence can omit the parsing. The language clients could be moved to the backend, too.
The text was updated successfully, but these errors were encountered: