Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling different versions of xterm.js #13896

Open
msujew opened this issue Jul 8, 2024 · 0 comments
Open

Pulling different versions of xterm.js #13896

msujew opened this issue Jul 8, 2024 · 0 comments
Labels
dependencies pull requests that update a dependency file terminal issues related to the terminal

Comments

@msujew
Copy link
Member

msujew commented Jul 8, 2024

I've noticed that we're pulling 2 different versions of xterm.js in our build. One in @theia/terminal:

"xterm": "^5.3.0",
"xterm-addon-fit": "^0.8.0",
"xterm-addon-search": "^0.13.0"

And in @theia/test:

"xterm": "^4.16.0",
"xterm-addon-fit": "^0.5.0"

We should probably update the one from @theia/test to align with the one from @theia/terminal. Maybe even re-export it?

We likely forgot to bump the version in both packages due to the long review time on #12691.

@msujew msujew added terminal issues related to the terminal dependencies pull requests that update a dependency file labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file terminal issues related to the terminal
Projects
None yet
Development

No branches or pull requests

1 participant