Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdowns in preference widget are not always properly rendered #13807

Open
tortmayr opened this issue Jun 12, 2024 · 4 comments
Open

Dropdowns in preference widget are not always properly rendered #13807

tortmayr opened this issue Jun 12, 2024 · 4 comments
Assignees
Labels
bug bugs found in the application ui/ux issues related to user interface / user experience

Comments

@tortmayr
Copy link
Contributor

Bug Description:

Clicking a dropdown preference in the PreferenceWidget does not show the selection overlay in certain corner cases.
If the clicked dropdown is near the end of the PreferenceWidget than the overlay does not get rendered if there is not enough available space to render it.
The following video demonstrates the issue:

theia.mp4

If there is remaining space after the preferences widget (i.e. some view is open in the bottom tab bar) everything works as expected.
However, if the bottom tab bar is closed, and you try to click a dropdown at near the bottom nothing happens and the overlay widget does not get rendered.

VSCode solves this issue by rendering the overlay bottom-up if there is not enough space below:

vscode.mp4

We should implement the same for Theia

Steps to Reproduce:

  1. Open the preferences widget (Ctrl+,)
  2. Close all bottom tabs (or move the Settings widget into the bottom tab)
  3. Choose any dropdown element from the preferences widget and bring it to the bottom of the application via scrolling
  4. Click the dropdown -> nothing happens and the selection overlay does not get rendered

Additional Information

  • Operating System: Ubuntu 22.04
  • Theia Version: 1.49.x
@msujew
Copy link
Member

msujew commented Jun 12, 2024

This was supposed to work, but maybe broke with #12038.

@tortmayr
Copy link
Contributor Author

Thanks for pointing out that is used to work. I was able to narrow it further down:

#12038 is not the culprit for this.
It works as expected for <= 1.45 but does no longer work with 1.46.

@msujew
Copy link
Member

msujew commented Jun 13, 2024

I see, then it was #13261.

@nayelimdejesus
Copy link

I'd like to work on this issue.

@msujew msujew added ui/ux issues related to user interface / user experience bug bugs found in the application labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application ui/ux issues related to user interface / user experience
Projects
None yet
Development

No branches or pull requests

3 participants