Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File icons not rendering in the tree view of custom plugins from theia version 1.41.0 to 1.44.0 #13251

Closed
hyddel opened this issue Jan 10, 2024 · 6 comments

Comments

@hyddel
Copy link

hyddel commented Jan 10, 2024

Bug Description:

File icons are not getting loading in the tree view of a custom plugin from theia version: 1.41.0 to 1.44.0.

Steps to Reproduce:

  1. start theia either through source code or theia blueprint, any theia version from 1.41.0 to 1.44.0
  2. install oci-core and oci-rms extensions
  3. Once they are installed, you need an OCI account. you can create an OCI Free Tier account
  4. Then under the OCI RMS plugin, expand the resources.
  5. Notice that the file icons are not getting loaded from theia versions: 1.41.0 to 1.44..0. They are getting loaded before 1.41.0 and from 1.45.0.
  6. After debugging, the result at this line matches with the result in 1.42.1 but file icons are not getting loaded.

Is it a known bug that got fixed in 1.45.0 ? Curious to know if there is any rendering not happening as expected ?

Below are the screenshots tried on Theia blueprint with theia version: 1.38.0 and 1.42.1
Screenshot 2024-01-04 141652 (1)
Screenshot 2024-01-04 142317 (1)

@JonasHelming
Copy link
Contributor

@planger Any idea?

@JonasHelming
Copy link
Contributor

Potentially related to #13213

@JonasHelming
Copy link
Contributor

@hyddel Could you quickly retest with 1.45 just to be sure?

@planger
Copy link
Contributor

planger commented Jan 10, 2024

No, without debugging into it I unfortunately don't have an idea why we don't see icons here. :-/ Sorry!

@msujew
Copy link
Member

msujew commented Jan 10, 2024

@hyddel @JonasHelming I assume that this is the same issue as #13096, which has been resolved with 1.45.0. See also #13101.

@hyddel
Copy link
Author

hyddel commented Jan 10, 2024

The fix from #13101 did work in theia 1.42.1. Thank you so much.

@hyddel hyddel closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants