Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change detection broken in Breakpoints #13052

Open
tsmaeder opened this issue Nov 3, 2023 · 0 comments
Open

Change detection broken in Breakpoints #13052

tsmaeder opened this issue Nov 3, 2023 · 0 comments
Labels
debug issues that related to debug functionality quality issues related to code and application quality

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Nov 3, 2023

Bug Description:

DebugSourceBreakpoint.updateOrigins() reaches into the existing breakpoint object and updates them in-place. This clashes with any attempts at change detection we make in BreakpointManager.setMarkers(). We should fix it such that changes to all objects are done through a designated owner which can do proper change detection and notify interested parties.
@tsmaeder tsmaeder added quality issues related to code and application quality debug issues that related to debug functionality labels Nov 3, 2023
@tsmaeder tsmaeder mentioned this issue Nov 3, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debug issues that related to debug functionality quality issues related to code and application quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsmaeder