Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Windows builds must pin Python to 3.11 #13008

Closed
kittaakos opened this issue Oct 19, 2023 · 1 comment · Fixed by #13011
Closed

CI: Windows builds must pin Python to 3.11 #13008

kittaakos opened this issue Oct 19, 2023 · 1 comment · Fixed by #13011

Comments

@kittaakos
Copy link
Contributor

Bug Description:

Currently, the builds are failing on Windows: https://github.com/eclipse-theia/theia/actions/runs/6559938239/job/17816557467#step:5:90

gyp info spawn args ]
Traceback (most recent call last):
  File "D:\a\theia\theia\node_modules\node-gyp\gyp\gyp_main.py", line 42, in <module>
    import gyp  # noqa: E402
    ^^^^^^^^^^
  File "D:\a\theia\theia\node_modules\node-gyp\gyp\pylib\gyp\__init__.py", line 9, in <module>
    import gyp.input
  File "D:\a\theia\theia\node_modules\node-gyp\gyp\pylib\gyp\input.py", line 19, in <module>
    from distutils.version import StrictVersion
ModuleNotFoundError: No module named 'distutils'
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1

We had the same issue downstream, and we had to pin the Python version.
Upstream issue: nodejs/node-gyp#2869
Our change: arduino/arduino-ide@97b0bc0
See PR: arduino/arduino-ide#2261

Steps to Reproduce:

Additional Information

  • Operating System: Windows
  • Theia Version:
@kittaakos
Copy link
Contributor Author

I have opened the issue for greater visibility. Ideally, a future node-gyp version update in Theia must unlock projects downstream to pin the minor Python version and stick to 3.x instead of 3.11.

kittaakos pushed a commit to kittaakos/theia that referenced this issue Oct 19, 2023
GH Actions comes with Python 3.12 by default if version 3.x specified.
`distutils` has been removed from 3.12, which causes a build problem
with `node-gyp`. This commit pins the Python version to 3.11 on the CI.

Ref: nodejs/node-gyp#2869

Closes eclipse-theia#13008

Signed-off-by: Akos Kitta <[email protected]>
tsmaeder pushed a commit that referenced this issue Oct 20, 2023
GH Actions comes with Python 3.12 by default if version 3.x specified.
`distutils` has been removed from 3.12, which causes a build problem
with `node-gyp`. This commit pins the Python version to 3.11 on the CI.

Ref: nodejs/node-gyp#2869

Closes #13008

Signed-off-by: Akos Kitta <[email protected]>
xai added a commit to eclipsesource/theia that referenced this issue Oct 31, 2023
Same problem and same solution as in eclipse-theia#13008.

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <[email protected]>
tsmaeder pushed a commit that referenced this issue Oct 31, 2023
Same problem and same solution as in #13008.

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <[email protected]>
planger added a commit to eclipsesource/theia-e2e-test-suite that referenced this issue Nov 1, 2023
Same problem and same solution as in
eclipse-theia/theia#13008.

Contributed on behalf of STMicroelectronics
planger added a commit to eclipse-theia/theia-e2e-test-suite that referenced this issue Nov 1, 2023
Same problem and same solution as in
eclipse-theia/theia#13008.

Contributed on behalf of STMicroelectronics
tortmayr pushed a commit to eclipse-theia/theia-e2e-test-suite that referenced this issue Nov 2, 2023
Same problem and same solution as in
eclipse-theia/theia#13008.

Contributed on behalf of STMicroelectronics
tortmayr pushed a commit to eclipse-theia/theia-e2e-test-suite that referenced this issue Nov 2, 2023
Same problem and same solution as in
eclipse-theia/theia#13008.

Contributed on behalf of STMicroelectronics
planger added a commit to eclipsesource/theia that referenced this issue Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant