Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposed API][builtins] Theia misses proposed API: ExternalUriOpener #12523

Closed
alvsan09 opened this issue May 11, 2023 · 1 comment · Fixed by #12539
Closed

[proposed API][builtins] Theia misses proposed API: ExternalUriOpener #12523

alvsan09 opened this issue May 11, 2023 · 1 comment · Fixed by #12539
Assignees
Labels
builtins Issues related to VS Code builtin extensions vscode issues related to VSCode compatibility

Comments

@alvsan09
Copy link
Contributor

alvsan09 commented May 11, 2023

Bug Description:

The following exception was encountered while activating built-in extensions in theia coming from vscode 1.77.2

2023-05-11T19:40:54.698Z root ERROR [hosted-plugin: 9798] Activating extension 'Simple Browser' failed: TypeError: vscode.window.registerExternalUriOpener is not a function
The extension uses the proposed API: ExternalUriOpener

Steps to Reproduce:

simple-browser-1.77.2-next.e344f1f539a.zip

  1. Download and change the extension of the file above to vsix
  2. Install it in 'theia', either via the Extensions view or by placing it inside the plugins folder
  3. Attempt to activate the extension by running the command Simple Browser: Show
  4. You will see a toast message stating that the activation of the Simple Browser (built-in) extension failed.

Additional Information

2023-05-11T19:40:54.698Z root ERROR [hosted-plugin: 9798] Activating extension 'Simple Browser' failed: TypeError: vscode.window.registerExternalUriOpener is not a function
    at activate (/home/lmcalvs/git/vscode4/extensions/simple-browser/out/extension.js:49:46)
    at PluginManagerExtImpl.startPlugin (/home/lmcalvs/git/theia2/packages/plugin-ext/lib/plugin/plugin-manager.js:310:81)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async /home/lmcalvs/git/theia2/packages/plugin-ext/lib/plugin/plugin-manager.js:219:21
    at async PluginManagerExtImpl.$activatePlugin (/home/lmcalvs/git/theia2/packages/plugin-ext/lib/plugin/plugin-manager.js:271:13)
    at async Promise.all (index 14)
    at async PluginManagerExtImpl.activateBySingleEvent (/home/lmcalvs/git/theia2/packages/plugin-ext/lib/plugin/plugin-manager.js:266:9)
    at async PluginManagerExtImpl.$activateByEvent (/home/lmcalvs/git/theia2/packages/plugin-ext/lib/plugin/plugin-manager.js:250:13)
    at async PluginManagerExtImpl.$start (/home/lmcalvs/git/theia2/packages/plugin-ext/lib/plugin/plugin-manager.js:148:9)
    at async RpcProtocol.handleRequest (/home/lmcalvs/git/theia2/packages/core/lib/common/message-rpc/rpc-protocol.js:167:28)
  • Operating System:
  • Theia Version:
@alvsan09 alvsan09 added vscode issues related to VSCode compatibility builtins Issues related to VS Code builtin extensions labels May 11, 2023
@alvsan09 alvsan09 self-assigned this May 15, 2023
@alvsan09
Copy link
Contributor Author

Fixed by: #12539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant