Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposed API][builtins] Theia misses proposed API: ProfileContentHandler #12520

Closed
marcdumais-work opened this issue May 11, 2023 · 0 comments · Fixed by #12535
Closed

[proposed API][builtins] Theia misses proposed API: ProfileContentHandler #12520

marcdumais-work opened this issue May 11, 2023 · 0 comments · Fixed by #12535
Assignees
Labels
builtins Issues related to VS Code builtin extensions vscode issues related to VSCode compatibility

Comments

@marcdumais-work
Copy link
Contributor

marcdumais-work commented May 11, 2023

Bug Description:

Testing locally-built vscode built-in extensions 1.77.0, I have encountered an issue with the activation of vscode.configuration-editing.

Key part of the exception:

2023-05-11T18:18:57.424Z root ERROR [hosted-plugin: 2790517] Activating extension 'Configuration Editing (built-in)' failed: TypeError: d.window.registerProfileContentHandler is not a function

It looks like it's using new proposed API: ProfileContentHandler

Full exception:

2023-05-11T18:18:57.412Z root INFO [hosted-plugin: 2790517] PLUGIN_HOST(2790517): PluginManagerExtImpl/loadPlugin(/tmp/vscode-unpacked/configuration-editing-1.77.0.vsix/extension/dist/configurationEditingMain)
2023-05-11T18:18:57.424Z root ERROR [hosted-plugin: 2790517] Activating extension 'Configuration Editing (built-in)' failed: TypeError: d.window.registerProfileContentHandler is not a function
    at 210 (/tmp/vscode-unpacked/configuration-editing-1.77.0.vsix/extension/dist/configurationEditingMain.js:2:408472)
    at a (/tmp/vscode-unpacked/configuration-editing-1.77.0.vsix/extension/dist/configurationEditingMain.js:2:419167)
    at /tmp/vscode-unpacked/configuration-editing-1.77.0.vsix/extension/dist/configurationEditingMain.js:2:422258
    at /tmp/vscode-unpacked/configuration-editing-1.77.0.vsix/extension/dist/configurationEditingMain.js:2:424869
    at Object.<anonymous> (/tmp/vscode-unpacked/configuration-editing-1.77.0.vsix/extension/dist/configurationEditingMain.js:2:424975)
    at Module._compile (node:internal/modules/cjs/loader:1174:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1229:10)
    at Module.load (node:internal/modules/cjs/loader:1044:32)
    at Module._load (node:internal/modules/cjs/loader:885:12)
    at f._load (node:electron/js2c/asar_bundle:2:13330)

Steps to Reproduce:

configuration-editing-1.77.0.zip

Additional Information

  • Operating System:
  • Theia Version:
@marcdumais-work marcdumais-work added vscode issues related to VSCode compatibility builtins Issues related to VS Code builtin extensions labels May 11, 2023
@vince-fugnitto vince-fugnitto self-assigned this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants