Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Yarn 3 and PnP support #11924

Open
daniel-brenot opened this issue Nov 25, 2022 · 2 comments
Open

Proposal: Yarn 3 and PnP support #11924

daniel-brenot opened this issue Nov 25, 2022 · 2 comments
Labels
proposal feature proposals (potential future features) quality issues related to code and application quality

Comments

@daniel-brenot
Copy link

Feature Description:

While this doesn't necessarily mean that the project needs to use yarn 3, having support for it would fix quite a few issues. For one, the project currently relies on links to files that exists within the node modules folder. Due to this, the only package resolution algorithm that can be used is one where every workspace has a copy of all the node_modules needed for the package, rather than having a single folder with the files, or even just resolving using pnp with no node modules.

If yarn 3 is used, the application will install much quicker. At the moment there may be a blocking point of node-pty due to its use of node-gyp, but I am currently working on that issue (microsoft/node-pty#507).

Let me know if this is of any interest. I am currently working on support and hope to commit it upstream if all goes well, but i wanted to make sure that the work would get merged.

@vince-fugnitto vince-fugnitto added quality issues related to code and application quality proposal feature proposals (potential future features) labels Nov 28, 2022
@nikitinas
Copy link

@daniel-brenot Please, do that! I have terrible pain with yarn classic due to my corporate proxy. Yarn 3 works fine, but I need Theia to support it. If you need any help with yarn 3 migration, please, contact me.

@danepowell
Copy link
Contributor

danepowell commented May 23, 2023

This will become more urgent with issues like isaacs/jackspeak#5

tl;dr Yarn 1 has bugs in its version resolution logic that make it impossible to use with certain packages using more advanced version definitions. The npm founder has mentioned that this will become more commonplace in the future, and we really need to migrate to a newer version of Yarn, or to NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal feature proposals (potential future features) quality issues related to code and application quality
Projects
None yet
Development

No branches or pull requests

4 participants