Modify theme services to use preference service #11473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR's primary objective is to modify the
ThemeService
andIconThemeService
to interact directly with thePreferenceService
as their primary source of truth. Previously, neither service wasinjectable
, and so neither had access to thePreferenceService
directly. As a consequence, their interactions with thePreferenceService
were mediated by theCommonFrontendContribution
and both services relied heavily on local storage for persistence.How to test
settings.json
and execute one of the commandsPreferences: Color Theme
orPreferences: Icon Theme
.settings.json
file is not modified.settings.json
is modified.settings.json
file, set a nonsensical value ("Definitely not any kind of theme!"
) for the preference.Check for #10938
settings.json
, setworkbench.iconTheme
to"material-icon-theme"
.Red
or something else with a distinctive editor background color.Review checklist
Reminder for reviewers