Move plugins to user folder during resolution #11466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11463 by changing the sequence of events involved in handling
.vsix
files to place them in the user plugin folder during the resolution stage rather than the handling phase. As a consequence, 'original' source files (for example in the resolution of an 'Install from VSIX' command) are not deleted on uninstallation.How to test
Install from VSIX
command and select a VSIX file outside of your user plugin folders.Reload Required
in the UI, and the vsix file should be removed from your user plugin folder.Reload Required
to restart the front end (don't restart the backend)Review checklist
Reminder for reviewers