terminal: buffer the output before sending #11449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to not overload the websocket channel opened between the frontend and the backend we should chunk and buffer the output of terminals. Add `BufferingStream` that will buffer data for some time before emitting it.
paul-marechal
force-pushed
the
mp/buffer-terminal-output
branch
from
5e6f046 to
cb435f4
Compare
1 task
msujew
reviewed
Jul 22, 2022
paul-marechal
force-pushed
the
mp/buffer-terminal-output
branch
from
b4107a7 to
60ebeca
Compare
msujew
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not overload the websocket channel opened between the
frontend and the backend we should chunk and buffer the output of
terminals.
Add
BufferingStreamthat will buffer data for some time beforeemitting it.
Closes #11181
How to test
Terminals should still work.
Review checklist
Reminder for reviewers