Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

too much viewWelcomeNodes #11283

Closed
meng-jpg opened this issue Jun 10, 2022 · 2 comments · Fixed by #11312
Closed

too much viewWelcomeNodes #11283

meng-jpg opened this issue Jun 10, 2022 · 2 comments · Fixed by #11312
Labels
bug bugs found in the application tree issues related to the tree (ex: tree widget)

Comments

@meng-jpg
Copy link
Contributor

Bug Description:

When the state of workspace is no folder opened, close the Explorer panel and open it from the View menu again.
Then one more visibleItem of the TreeViewWelcomeWidget will be displayed.
This may be caused by the response mode of the onDidCreateWidget event and the storage form of the viewWelcome nodes.

Steps to Reproduce:

  1. run theia electron
  2. right click on the explorer icon to call the context menu
  3. choose close
  4. reopen the panel from View->Explorer

截屏2022-06-10 下午2 15 32

Additional Information

  • Operating System: macOS Big Sur 11.2
  • Theia Version: 1.25
@colin-grant-work colin-grant-work added the tree issues related to the tree (ex: tree widget) label Jun 10, 2022
@inlann
Copy link
Contributor

inlann commented Jun 14, 2022

Theia 1.26 still has this bug

@yiliang114
Copy link
Contributor

image

Same error in Theia Web (examples/browser)1.26

@msujew msujew added the bug bugs found in the application label Jun 20, 2022
@msujew msujew mentioned this issue Jun 20, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application tree issues related to the tree (ex: tree widget)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dispose explorer view welcome correctly eclipse-theia/theia
5 participants
@msujew @yiliang114 @inlann @colin-grant-work @meng-jpg