Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks in VSCode VSIX to be stubbed out #11100

Closed
MatthewKhouzam opened this issue May 3, 2022 · 4 comments
Closed

Notebooks in VSCode VSIX to be stubbed out #11100

MatthewKhouzam opened this issue May 3, 2022 · 4 comments
Labels
notebook issues related to notebooks vscode issues related to VSCode compatibility

Comments

@MatthewKhouzam
Copy link
Contributor

Bug Description:

The Notebook API is blocking some modern python plug-ins from being compatible with Theia, as well as Jupyter notebooks. This blocks off the AI/ML crowd from using Theia. A stop-gap solution would be to stub out the APIs at first and see which ones need fixing next.

@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility notebook issues related to notebooks labels May 3, 2022
@JonasHelming
Copy link
Contributor

One thing we would need to think about is how to communicate that this is stubbed. Otherwise I am in full favor of stubbing it for now. @planger

@planger
Copy link
Contributor

planger commented May 6, 2022

Right, stubbing out certain API to make extensions at least work with the other API that is fully supported would certainly help in many cases. However, if something is just stubbed, I think we should make very clear that it isn't "functionally" supported.

I would maybe suggest to enhance the vscode-theia-comparator info.yml, allowing to mark namespaces/types specifically as stubbed, so that they show up as warning (orange), meaning that the types are available but actually not functional. WDYT?

@JonasHelming
Copy link
Contributor

sound like a good idea to me!

@vince-fugnitto
Copy link
Member

Closing in favor of #11786.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

4 participants