-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with window.titleBarStyle
on Linux systems
#10843
Comments
@orange-pig, I have created an issue to track the problem you've encountered, and I'll look into reproducing it |
By debug, it look like that because a sync process problem in start, the ElectronMenuContribution.onStart() is not executed, the quetions has happening. But I don't have hard evidence yet, then will to trace it. |
It turns out my guess above was wrong in the last commit, it's just my debugging phenomenon. I guess I found the reason of the bug, the real reason is 133 line in the file core/src/eelectron-browser/menu/electron-menu-contribution.ts
|
@orange-pig Thanks for tracking this down. I created a fix for this in #10847, do you mind trying it out? |
@msujew Good, It works fine. |
I get the same problem now, when I try upgrade theia to 1.23.0. from 1.18.0.
After build the electron and start, I got it. No titlebar & top menu, only the content be display.
And I try to set window: Title bar style custom -> native, it will be have a windows tile bar. (other: The restart window look like do not show always.)
So, the window title bar style be default custom in new version, but it can't work in my PC, and then build electron installer running in other PC still so.
And, I try to delete .theia/ in user folder, still so.
And, I try to delete electron/ in AppData folder, still so.
I am using:
node.js: 14.18.1
typescript: 4.5.5
Originally posted by @orange-pig in #10044 (comment)
The text was updated successfully, but these errors were encountered: