Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferences: setting invalid preference value results in unresponsive application #10599

Closed
vince-fugnitto opened this issue Jan 5, 2022 · 0 comments · Fixed by #10607
Closed
Assignees
Labels
bug bugs found in the application preferences issues related to preferences

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

When a preference is set with an invalid value, the application will become unresponsive.
The value tested with is later used by monaco which may cause the actual issue.

The console is flooded with the following repeating error:

errors.ts:28 Uncaught Error: Invalid string length

RangeError: Invalid string length
    at IndentGuidesOverlay.prepareRender (indentGuides.ts:144)
    at ContentViewOverlays.ViewOverlays.prepareRender (viewOverlays.ts:125)
    at View._actualRender (viewImpl.ts:412)
    at viewImpl.ts:360
    at safeInvokeNoArg (viewImpl.ts:552)
    at View._renderNow (viewImpl.ts:360)
    at View._flushAccumulatedAndRenderNow (viewImpl.ts:230)
    at View._onRenderScheduled (viewImpl.ts:356)
    at AnimationFrameQueueItem.execute (dom.ts:210)
    at animationFrameRunner (dom.ts:250)
    at errors.ts:28

Steps to Reproduce:

  1. start the application with theia as a workspace.
  2. open the dev console to view logs.
  3. open the settings.json file for the user or workspace scope.
  4. add "editor.tabSize": 2 if it doesn't already exist - the application should work fine.
  5. update the value to "editor.tabSize": "true" - the application becomes unresponsive, and the default value is not used.

image

@vince-fugnitto vince-fugnitto added bug bugs found in the application preferences issues related to preferences labels Jan 5, 2022
@colin-grant-work colin-grant-work self-assigned this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application preferences issues related to preferences
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants