Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow duplicate editors to exist in the same group #10409

Closed
kenneth-marut-work opened this issue Nov 11, 2021 · 1 comment
Closed

Don't allow duplicate editors to exist in the same group #10409

kenneth-marut-work opened this issue Nov 11, 2021 · 1 comment
Labels
editor issues related to the editor open-editors issues related to the open-editors view

Comments

@kenneth-marut-work
Copy link
Contributor

Bug Description:

When splitting an editor horizontally it opens the second instance in a new editor group (tabbar). Currently, if you drag the second editor back into the same group as the first editor you end up with two identical editors in the same tabbar. In VSCode, the second editor is automatically closed so you don't end up with something like this:

image

Steps to Reproduce:

  1. Open an editor
  2. Split it horizontally or vertically
  3. Drag the second instance into the same tabbar as the first editor
  4. Observe that you end up with multiple listings for the same editor in the open editors view and that all editors are allowed to exist on the same tabbar
  5. Try this in VSCode and observe that the second instance is automatically closed

Additional Information

  • Operating System: Linux
  • Theia Version: master
@kenneth-marut-work kenneth-marut-work added editor issues related to the editor open-editors issues related to the open-editors view labels Nov 11, 2021
@vince-fugnitto
Copy link
Member

I believe the issue is fixed with #12147. If we split an editor and attempt to add it to a group that already has the editor the editor is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor open-editors issues related to the open-editors view
Projects
None yet
Development

No branches or pull requests

2 participants