Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace: open recent workspace... menu displays incorrect icon for current workspace #10173

Closed
vince-fugnitto opened this issue Sep 27, 2021 · 0 comments · Fixed by #10174
Closed
Labels
ui/ux issues related to user interface / user experience workspace issues related to the workspace

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The Workspace: Open Recent Workspace... quick-input displays an incorrect icon for the currently opened workspace folder when using the theia-file-icon theme. For other themes the icon is displayed properly.

recent-workspaces.mp4

The changes are using the WorkspaceUriLabelProvider which was updated for breadcrumbs support (#9920), and its likely that the iconClass has no associated icon (rootfolder-icon):

getIcon(element: URI | URIIconReference | FileStat): string {
const uri = this.getUri(element);
if (uri && this.workspaceVariable.getWorkspaceRootUri(uri)?.isEqual(uri)) {
return 'rootfolder-icon';
}
return super.getIcon(this.asURIIconReference(element));
}

cc @colin-grant-work

Steps to Reproduce:

  1. start the application, and ensure that there is a recent workspace history (open multiple workspaces)
  2. trigger F1 > Open Recent Workspace...
  3. identify that the icon for the current workspace is not displayed
@vince-fugnitto vince-fugnitto added workspace issues related to the workspace ui/ux issues related to user interface / user experience labels Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience workspace issues related to the workspace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant