Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dirty Files + Reset Workbench Layout ---> Exit Rather than Reload #10090

Closed
colin-grant-work opened this issue Sep 13, 2021 · 0 comments · Fixed by #10379
Closed

Dirty Files + Reset Workbench Layout ---> Exit Rather than Reload #10090

colin-grant-work opened this issue Sep 13, 2021 · 0 comments · Fixed by #10379
Labels
core issues related to the core of the application electron issues related to the electron target

Comments

@colin-grant-work
Copy link
Contributor

Bug Description:

The dirty file exit handler doesn't play nicely with a reload initiated by 'Reset workbench layout'

Steps to Reproduce:

  1. Open Electron application
  2. Dirty some files
  3. Run Reset workbench layout
  4. See prompt about exiting with dirty files.
  5. Answer Yes, you'd like to exit.
  6. Observe that application exits but doesn't restart.

Additional Information

  • Operating System: RHEL7
  • Theia Version: master
@colin-grant-work colin-grant-work added the core issues related to the core of the application label Sep 13, 2021
@colin-grant-work colin-grant-work added the electron issues related to the electron target label Nov 3, 2021
@colin-grant-work colin-grant-work mentioned this issue Nov 3, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core issues related to the core of the application electron issues related to the electron target
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve handling of close and reload events eclipse-theia/theia
1 participant
@colin-grant-work