From d145b055edc304bf3c9a18cc6b57be66018fcf48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9rome=20Perrin?= Date: Mon, 30 Nov 2020 01:27:02 +0000 Subject: [PATCH] download-plugins: report a failure in case of unsupported file type MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If a plugin url listed in theiaPlugins in package.json is not supported, it should be reported as a failure and not only logged. Signed-off-by: Jérome Perrin --- dev-packages/cli/src/download-plugins.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/cli/src/download-plugins.ts b/dev-packages/cli/src/download-plugins.ts index 4ba087e7ba260..809a52321a9ae 100644 --- a/dev-packages/cli/src/download-plugins.ts +++ b/dev-packages/cli/src/download-plugins.ts @@ -108,7 +108,7 @@ async function downloadPluginAsync(failures: string[], plugin: string, pluginUrl } else if (pluginUrl.endsWith('vsix')) { fileExt = '.vsix'; } else { - console.error(red(`error: '${plugin}' has an unsupported file type: '${pluginUrl}'`)); + failures.push(red(`error: '${plugin}' has an unsupported file type: '${pluginUrl}'`)); return; } const targetPath = path.join(process.cwd(), pluginsDir, `${plugin}${packed === true ? fileExt : ''}`);