From 618b5a8c2fbc069b398b5de65f9af489a1c10073 Mon Sep 17 00:00:00 2001 From: Muhammad Anas Shahid Date: Fri, 24 Jan 2020 11:49:12 -0500 Subject: [PATCH] Core: Do no expand the widgets on the side-bars for the context menu Before, right clicking on different menus would focus the menu item and open it, however this should not be the case. There was a dangling code in the handleContextMenu which causes this effect, as it was checking for the id when right clicked and looked up the ID for the menu-item and set the current title to the menu-item. Issue ID: 4367 Signed-off-by: Muhammad Anas Shahid --- packages/core/src/browser/shell/tab-bars.ts | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/packages/core/src/browser/shell/tab-bars.ts b/packages/core/src/browser/shell/tab-bars.ts index 56479de17fcef..89ee5a1d29fad 100644 --- a/packages/core/src/browser/shell/tab-bars.ts +++ b/packages/core/src/browser/shell/tab-bars.ts @@ -413,18 +413,6 @@ export class TabBarRenderer extends TabBar.Renderer { if (this.contextMenuRenderer && this.contextMenuPath && event.currentTarget instanceof HTMLElement) { event.stopPropagation(); event.preventDefault(); - - if (this.tabBar) { - const id = event.currentTarget.id; - // tslint:disable-next-line:no-null-keyword - const title = this.tabBar.titles.find(t => this.createTabId(t) === id) || null; - this.tabBar.currentTitle = title; - this.tabBar.activate(); - if (title) { - title.owner.activate(); - } - } - this.contextMenuRenderer.render(this.contextMenuPath, event); } }