From 483e0a20bd13faabf148060fc50d484517439f89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Paul=20Mar=C3=A9chal?= Date: Thu, 27 Jul 2023 12:57:27 -0400 Subject: [PATCH] fix backend cli --- packages/core/src/node/backend-application.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/core/src/node/backend-application.ts b/packages/core/src/node/backend-application.ts index 5d68913891bc6..cb50573ff9014 100644 --- a/packages/core/src/node/backend-application.ts +++ b/packages/core/src/node/backend-application.ts @@ -30,6 +30,8 @@ import { AddressInfo } from 'net'; import { ApplicationPackage } from '@theia/application-package'; import { ProcessUtils } from './process-utils'; +export type DnsResultOrder = 'ipv4first' | 'verbatim' | 'nodeDefault'; + const APP_PROJECT_PATH = 'app-project-path'; const TIMER_WARNING_THRESHOLD = 50; @@ -37,8 +39,8 @@ const TIMER_WARNING_THRESHOLD = 50; const DEFAULT_PORT = environment.electron.is() ? 0 : 3000; const DEFAULT_HOST = 'localhost'; const DEFAULT_SSL = false; +const DEFAULT_DNS_DEFAULT_RESULT_ORDER: DnsResultOrder = 'ipv4first'; -export type DnsResultOrder = 'ipv4first' | 'verbatim' | 'nodeDefault'; export const BackendApplicationServer = Symbol('BackendApplicationServer'); /** @@ -110,7 +112,7 @@ export class BackendApplicationCliContribution implements CliContribution { port: number; hostname: string | undefined; - dnsDefaultResultOrder: DnsResultOrder; + dnsDefaultResultOrder: DnsResultOrder = DEFAULT_DNS_DEFAULT_RESULT_ORDER; ssl: boolean | undefined; cert: string | undefined; certkey: string | undefined; @@ -127,7 +129,7 @@ export class BackendApplicationCliContribution implements CliContribution { type: 'string', description: 'Configure Node\'s DNS resolver default behavior, see https://nodejs.org/docs/latest-v18.x/api/dns.html#dnssetdefaultresultorderorder', choices: ['ipv4first', 'verbatim', 'nodeDefault'], - default: 'ipv4first', + default: DEFAULT_DNS_DEFAULT_RESULT_ORDER }); }