From 2f92a1627e9e6a9111e784b7417b096409421ede Mon Sep 17 00:00:00 2001 From: vince-fugnitto Date: Fri, 29 Oct 2021 09:56:01 -0400 Subject: [PATCH] plugin: update `resolveSystemPlugins` default The commit updates the `resolveSystemPlugins` backend application prop to `false` since it has the better behavior. The flag was initially set to `true` not to have breaking behavior changes as part of `v1.19.0`. The prop is used to not resolve system extension-packs and dependencies at runtime, and instead resolve them at buildtime. Signed-off-by: vince-fugnitto --- doc/Migration.md | 6 +++--- .../src/hosted/node/hosted-plugin-deployer-handler.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/Migration.md b/doc/Migration.md index d8fe2ac585014..199836b16a2d8 100644 --- a/doc/Migration.md +++ b/doc/Migration.md @@ -13,9 +13,9 @@ Please see the latest version (`master`) for the most up-to-date information. Pl Introduced in `v1.19.0` was the feature to better support extension-packs which both contribute functionality and reference plugins (by `id`). The feature works best when there is no runtime plugin resolvement for system (builtin) plugins as it should be done at build time instead. -In order not to change behavior today, the feature is behind an application prop (acting as a flag). If you want to enable better support for -extension-packs and extension-dependencies as builtins the property should be turned off. You can disable the resolvement in your application's -`package.json` like so: +The feature is behind an application property, acting as a flag to enable/disable the feature. If you want to enable better support for +extension-packs and extension-dependencies as builtins the property should be turned off (default). You can enable/disable the resolution of system +plugin dependencies in your application's `package.json` like so: ```json diff --git a/packages/plugin-ext/src/hosted/node/hosted-plugin-deployer-handler.ts b/packages/plugin-ext/src/hosted/node/hosted-plugin-deployer-handler.ts index 35b5314771351..042fd1c5a5fa8 100644 --- a/packages/plugin-ext/src/hosted/node/hosted-plugin-deployer-handler.ts +++ b/packages/plugin-ext/src/hosted/node/hosted-plugin-deployer-handler.ts @@ -86,7 +86,7 @@ export class HostedPluginDeployerHandler implements PluginDeployerHandler { const metadata = this.reader.readMetadata(manifest); const dependencies: PluginDependencies = { metadata }; // Do not resolve system (aka builtin) plugins because it should be done statically at build time. - const { resolveSystemPlugins = true } = BackendApplicationConfigProvider.get(); + const { resolveSystemPlugins = false } = BackendApplicationConfigProvider.get(); if (resolveSystemPlugins || entry.type !== PluginType.System) { dependencies.mapping = this.reader.readDependencies(manifest); }