Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badge to Readme showing the status of the "next" build #123

Open
JonasHelming opened this issue Nov 28, 2021 · 5 comments
Open

Add badge to Readme showing the status of the "next" build #123

JonasHelming opened this issue Nov 28, 2021 · 5 comments

Comments

@JonasHelming
Copy link
Contributor

If the build on main fails, it is likely that the underlying Theia project has some API breakage. We should notify interested parties, either some committer or a mailing list in this case. @vince-fugnitto @marcdumais-work Any thoughts on this?

see also #122 introducing a build against "next"

@vince-fugnitto
Copy link
Member

@JonasHelming I think the mailing list would be too noisy if we start sending emails when the build fails, perhaps whoever is interested can turn on their settings for failed builds? The only issue is that it might not be granular to which repo they want notifications for:

image

We could also add a badge in the main-repo's readme (similarly to vscode-builtin-extensions) to display the build status of the generator.

@JonasHelming
Copy link
Contributor Author

@vince-fugnitto Do you get notifications on this repo? If so, if it is at least you and me, I believe we are good already.

@vince-fugnitto
Copy link
Member

@vince-fugnitto Do you get notifications on this repo? If so, if it is at least you and me, I believe we are good already.

@JonasHelming I believe so, and I agree that it's likely enough, we would not want to add noise to the mailing list about failed builds in the generator 👍

@JonasHelming
Copy link
Contributor Author

OK let us wait until the tree editor is fixed then

@JonasHelming JonasHelming changed the title Add mail notifcations for failed builds Add badge to Readme showing the status of the "next" build Dec 10, 2021
@JonasHelming
Copy link
Contributor Author

Depending on the outcome of the discussion here: eclipse-theia/theia-ide#186
We also might want to add the badge to the Theia repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants