Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[di] consider injecting services from Theia directly #27

Open
JanKoehnlein opened this issue Mar 4, 2019 · 0 comments
Open

[di] consider injecting services from Theia directly #27

JanKoehnlein opened this issue Mar 4, 2019 · 0 comments

Comments

@JanKoehnlein
Copy link
Contributor

Currently, we use the (LS)TheiaSprottyConnector to get access to Theia services from within sprotty.

We could as well have these injected in the diagram configuration, which is created using the Theia DI container, and then bind these instances in the resp. Sprotty container. This would result in far less constructor injection and much better configurable dependencies between Theia and Sprotty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JanKoehnlein