Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge smoothness setting not taken into account #352

Open
pcdavid opened this issue Apr 9, 2024 · 0 comments · May be fixed by #353
Open

Edge smoothness setting not taken into account #352

pcdavid opened this issue Apr 9, 2024 · 0 comments · May be fixed by #353
Assignees
@pcdavid
Labels
component: diagrams type: bug Something isn't working
Milestone
Next maintenance

Comments

@pcdavid
Copy link
Member

pcdavid commented Apr 9, 2024 •
edited by lredor
Loading

Since commit ade8fa1 (I think) and related work on jump links which introduced our own custom SiriusPolylineConnectionEx extends PolylineConnectionEx the smoothness setting on GMF edges is non-effective.
The org.eclipse.gmf.runtime.diagram.ui.editparts.ConnectionEditPart.refreshSmoothness() code does nothing for our own subclass. It should be overridden on our side (in AbstractDiagramEdgeEditPart) to do the equivalent change on our SiriusPolylineConnectionEx.

Steps to reproduce:

  1. Open a diagram with at least one edge.
  2. Select the edge and make sure it has at least one bendpoint.
  3. In the Properties view, open the Appearance tab and change the Smoothess setting to "More".
  4. Expected: the edge should become a smooth curve instead of a sequence of straight segments.
@pcdavid pcdavid added type: bug Something isn't working component: diagrams labels Apr 9, 2024
pcdavid added a commit that referenced this issue Apr 9, 2024
@pcdavid
[352] Fix edge smoothness setting
de3fefd 
Bug: #352
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid linked a pull request Apr 9, 2024 that will close this issue
Open
@pcdavid pcdavid added this to the v7.4.2 milestone Apr 9, 2024
@pcdavid pcdavid linked a pull request Apr 9, 2024 that will close this issue
[352] Fix edge smoothness setting #353
Open
@pcdavid pcdavid modified the milestones: v7.4.2, v7.4.3 Jun 20, 2024
pcdavid added a commit that referenced this issue Jun 27, 2024
@pcdavid
[352] Fix edge smoothness setting
cba2097 
Bug: #352
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Jul 31, 2024
@pcdavid
[352] Fix edge smoothness setting
f92df81 
Bug: #352
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid modified the milestones: v7.4.3, v7.4.4 Aug 30, 2024
@pcdavid pcdavid modified the milestones: v7.4.4, v7.4.5 Sep 26, 2024
@pcdavid pcdavid modified the milestones: v7.4.5, v7.4.6 Nov 14, 2024
@pcdavid pcdavid modified the milestones: v7.4.6, Next maintenance Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
component: diagrams type: bug Something isn't working
Projects
None yet
Milestone
Next maintenance
Development

Successfully merging a pull request may close this issue.

[352] Fix edge smoothness setting eclipse-sirius/sirius-desktop
1 participant
@pcdavid