Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing an edge may give the impression the wrong edge has been removed #931

Closed
4 tasks done
gcoutable opened this issue Jan 7, 2022 · 1 comment · Fixed by #1218
Closed
4 tasks done

Removing an edge may give the impression the wrong edge has been removed #931

gcoutable opened this issue Jan 7, 2022 · 1 comment · Fixed by #1218
Assignees
@gcoutable
Labels
difficulty: medium type: bug
Milestone
2022.11.0

Comments

@gcoutable
Copy link
Member

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • latest
  • I have specified my environment :
  • my computer: Windows

Screenshots

Issue-removing-an-edge.mp4

Steps to reproduce

  1. Create two edges between two same elements
  2. Remove the first edge created

Expected behavior

The remaining edge keeps its position

Actual behavior

The remaining edge take the position of the removed edge
@gcoutable
Copy link
Member Author

Since many edges can be displayed between two same elements, a hidden issue is now visible.
This behavior is due to the way edge ids are defined. Among other parameters, we use the number of edges present in the diagram to calculate the id of an edge. Which explains the actual behavior.

To fix this issue we should rely on edge anchors instead of a counter to build edge ids.

@sbegaudeau sbegaudeau added this to the 2022.03.0 milestone Jan 21, 2022
@sbegaudeau sbegaudeau removed this from the 2022.03.0 milestone Mar 9, 2022
@gcoutable gcoutable added this to the 2022.5.0 milestone May 12, 2022
@gcoutable gcoutable self-assigned this May 12, 2022
gcoutable added a commit that referenced this issue May 13, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
587d12e 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable added a commit that referenced this issue May 13, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
1a23e93 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
@gcoutable gcoutable mentioned this issue May 13, 2022
Merged
39 tasks
gcoutable added a commit that referenced this issue May 13, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
a80a638 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
@gcoutable gcoutable linked a pull request May 16, 2022 that will close this issue
[931] Improve edge graphical removal #1218
Merged
39 tasks
@gcoutable gcoutable modified the milestones: 2022.5.0, 2022.7.0 May 30, 2022
gcoutable added a commit that referenced this issue Jun 1, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
ffeac66 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable added a commit that referenced this issue Jun 14, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
3f71651 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
@sbegaudeau sbegaudeau modified the milestones: 2022.7.0, 2022.9.0 Jul 25, 2022
gcoutable added a commit that referenced this issue Sep 7, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
15f6948 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable added a commit that referenced this issue Sep 7, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
7bc26a3 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
@sbegaudeau sbegaudeau modified the milestones: 2022.9.0, 2022.11.0 Sep 13, 2022
gcoutable added a commit that referenced this issue Sep 20, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
7f14143 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable added a commit that referenced this issue Sep 20, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
6e56cd2 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable added a commit that referenced this issue Sep 20, 2022
@gcoutable
[931] Removing an edge does not affect position of other edges
90b7470 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
@gcoutable gcoutable mentioned this issue Sep 20, 2022
Merged
39 tasks
sbegaudeau pushed a commit that referenced this issue Oct 5, 2022
@gcoutable @sbegaudeau
[931] Removing an edge does not affect position of other edges
0abb24b 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau pushed a commit that referenced this issue Oct 6, 2022
@gcoutable @sbegaudeau
[931] Removing an edge does not affect position of other edges
b6c22f7 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau pushed a commit that referenced this issue Oct 6, 2022
@gcoutable @sbegaudeau
[931] Removing an edge does not affect position of other edges
f57458e 
Bug: #931
Signed-off-by: Guillaume Coutable <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcoutable gcoutable

Labels
difficulty: medium type: bug
Projects
None yet
Milestone
2022.11.0
Development

Successfully merging a pull request may close this issue.

[931] Improve edge graphical removal eclipse-sirius/sirius-web
2 participants
@sbegaudeau @gcoutable