Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a ViewDeletionRequest #672

Closed
12 tasks
sbegaudeau opened this issue Jul 30, 2021 · 1 comment · Fixed by #733
Closed
12 tasks

Add support for a ViewDeletionRequest #672

sbegaudeau opened this issue Jul 30, 2021 · 1 comment · Fixed by #733
Assignees
@hmarchadour
Labels
difficulty: medium package: diagrams size: smallbatch type: feature request
Milestone
0.5.0

Comments

@sbegaudeau
Copy link
Member

sbegaudeau commented Jul 30, 2021 •
edited
Loading

Problem

In order to support unsynchronized diagrams, we have added the concept of ViewCreationRequest in order to add an unsynchronized view to a diagram. In a similar fashion, we need to be able to delete such element from the diagram.

Solution

We will add the concept of ViewDeletionRequest and handle it in the NodeComponent.

Cutting backs

Rabbit holes

No-gos

Test

  • Automated developer tests merged and pass (with reasonable code coverage)
  • Automated End-to-End tests merged and pass (Cypress)
  • Feature/bug fix manually tested/validated by at least one person not involved in the implementation
  • Collaborative tests passed by hand
  • Exploratory test passed by MEB
  • Business acceptance test passed by MEB

Doc

  • Internal Doc updated
  • External Doc updated
  • Validation Doc updated

UX/UI

  • Zeroheight updated
  • Storybook updated

Next

  • Any left-over tasks in the Github issues
@sbegaudeau sbegaudeau added this to the 0.5.0 milestone Jul 30, 2021
@sbegaudeau
Copy link
Member Author

See the relevant ADR for more information: https://github.com/eclipse-sirius/sirius-components/blob/master/doc/adrs/024_add_support_for_view_deletion_requests.adoc

hmarchadour pushed a commit that referenced this issue Aug 24, 2021
[672] Add support for a ViewDeletionRequest
64a6c29 
Bug: #672
Signed-off-by: Hugo Marchadour <[email protected]>
hmarchadour pushed a commit that referenced this issue Aug 25, 2021
[672] Add support for a ViewDeletionRequest
00c2f7e 
Bug: #672
Signed-off-by: Hugo Marchadour <[email protected]>
hmarchadour pushed a commit that referenced this issue Aug 25, 2021
[672] Add support for a ViewDeletionRequest
7b8f09f 
Bug: #672
Signed-off-by: Hugo Marchadour <[email protected]>
hmarchadour pushed a commit that referenced this issue Aug 25, 2021
[672] Add support for a ViewDeletionRequest
36f5330 
Bug: #672
Signed-off-by: Hugo Marchadour <[email protected]>
hmarchadour pushed a commit that referenced this issue Sep 17, 2021
[672] Add support for a ViewDeletionRequest
88de539 
Bug: #672
Signed-off-by: Hugo Marchadour <[email protected]>
hmarchadour pushed a commit that referenced this issue Sep 20, 2021
[672] Add support for a ViewDeletionRequest
43f963a 
Bug: #672
Signed-off-by: Hugo Marchadour <[email protected]>
sbegaudeau pushed a commit that referenced this issue Sep 21, 2021
@sbegaudeau
[672] Add support for a ViewDeletionRequest
2a0475c 
Bug: #672
Signed-off-by: Hugo Marchadour <[email protected]>
sbegaudeau pushed a commit that referenced this issue Sep 22, 2021
@sbegaudeau
[672] Add support for a ViewDeletionRequest
9c5462a 
Bug: #672
Signed-off-by: Hugo Marchadour <[email protected]>
@sbegaudeau sbegaudeau linked a pull request Sep 22, 2021 that will close this issue
Add support for a ViewDeletionRequest #733
Merged
17 tasks
sbegaudeau pushed a commit that referenced this issue Sep 22, 2021
@sbegaudeau
[672] Add support for a ViewDeletionRequest
53c32ad 
Bug: #672
Signed-off-by: Hugo Marchadour <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmarchadour hmarchadour

Labels
difficulty: medium package: diagrams size: smallbatch type: feature request
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Add support for a ViewDeletionRequest eclipse-sirius/sirius-web
2 participants
@sbegaudeau @hmarchadour