Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets with no style should not inherit style properties #2144

Closed
4 tasks done
AxelRICHARD opened this issue Jul 3, 2023 · 0 comments · Fixed by #2145
Closed
4 tasks done

Widgets with no style should not inherit style properties #2144

AxelRICHARD opened this issue Jul 3, 2023 · 0 comments · Fixed by #2145
Assignees
@AxelRICHARD
Labels
difficulty: starter package: forms type: bug
Milestone
2023.8.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • 2023.6.4
  • I have specified my environment :
  • All

Screenshots

Capture d’écran 2023-07-03 à 11 20 41

Steps to reproduce

Just open any properties View

Expected behavior

When widgets have no defined style, then their style properties should not be set to 'inherit', but to undefined.

Actual behavior

When widgets have no defined style, then their style properties are set to 'inherit', which could lead to get wrong default values.
For example:

  • textfields with domain type or aql expressions have a 17px height instead of 19px height for other textfields.
  • labels font size is smaller than textfields font size
@AxelRICHARD AxelRICHARD added this to the 2023.8.0 milestone Jul 3, 2023
@AxelRICHARD AxelRICHARD self-assigned this Jul 3, 2023
AxelRICHARD added a commit that referenced this issue Jul 3, 2023
@AxelRICHARD
[2144] Fix default properties values for widgets with no style
540b6ef 
Bug: #2144
Signed-off-by: Axel RICHARD <[email protected]>
@AxelRICHARD AxelRICHARD mentioned this issue Jul 3, 2023
Merged
39 tasks
@AxelRICHARD AxelRICHARD linked a pull request Jul 3, 2023 that will close this issue
[2144] Fix default properties values for widgets with no style #2145
Merged
39 tasks
AxelRICHARD added a commit that referenced this issue Jul 5, 2023
@AxelRICHARD
[2144] Fix default properties values for widgets with no style
75e11fb 
Bug: #2144
Signed-off-by: Axel RICHARD <[email protected]>
AxelRICHARD added a commit that referenced this issue Jul 6, 2023
@AxelRICHARD
[2144] Fix default properties values for widgets with no style
221c948 
Bug: #2144
Signed-off-by: Axel RICHARD <[email protected]>
AxelRICHARD added a commit that referenced this issue Jul 7, 2023
@AxelRICHARD
[2144] Fix default properties values for widgets with no style
1322930 
Bug: #2144
Signed-off-by: Axel RICHARD <[email protected]>
@AxelRICHARD AxelRICHARD mentioned this issue Dec 8, 2023
Draft
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
difficulty: starter package: forms type: bug
Projects
None yet
Milestone
2023.8.0
Development

Successfully merging a pull request may close this issue.

[2144] Fix default properties values for widgets with no style eclipse-sirius/sirius-web
1 participant
@AxelRICHARD