Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the workbench selection with react-flow #2034

Closed
gcoutable opened this issue Jun 6, 2023 · 0 comments · Fixed by #2035
Closed

Integrate the workbench selection with react-flow #2034

gcoutable opened this issue Jun 6, 2023 · 0 comments · Fixed by #2035
Assignees
@gcoutable
Labels
difficulty: medium package: diagrams type: feature request
Milestone
2023.8.0

Comments

@gcoutable
Copy link
Member

No description provided.

@gcoutable gcoutable added this to the 2023.6.0 milestone Jun 6, 2023
@gcoutable gcoutable self-assigned this Jun 6, 2023
gcoutable added a commit that referenced this issue Jun 6, 2023
@gcoutable
[2034] Integrate workbench selection with react-flow
16c613f 
TODO:

- selection on edges
- selection on diagram background
- Selection on image node (update the style if selected)
- Ask SBE if selection on list item (a palette could appear in the next
PR)
There is some work to do on list-item, it must be extracted from node
list
- cleanup

NOTE:

- The hover may be tricky to integrate

Bug: #2034
Signed-off-by: Guillaume Coutable <[email protected]>
@gcoutable gcoutable linked a pull request Jun 6, 2023 that will close this issue
Integrate the workbench selection with react-flow #2035
Merged
39 tasks
gcoutable added a commit that referenced this issue Jun 7, 2023
@gcoutable
[2034] Integrate workbench selection with react-flow on node
f65fbad 
Bug: #2034
Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable added a commit that referenced this issue Jun 7, 2023
@gcoutable
[2034] Integrate workbench selection with react-flow on node
cbf8d6e 
Bug: #2034
Signed-off-by: Guillaume Coutable <[email protected]>
@sbegaudeau sbegaudeau modified the milestones: 2023.6.0, 2023.8.0 Jun 8, 2023
sbegaudeau pushed a commit that referenced this issue Jun 8, 2023
@gcoutable @sbegaudeau
[2034] Integrate workbench selection with react-flow on node
a94807c 
Bug: #2034
Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jun 9, 2023
@gcoutable @sbegaudeau
[2034] Integrate workbench selection with react-flow on node
48a8d40 
Bug: #2034
Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jun 9, 2023
@gcoutable @sbegaudeau
[2034] Integrate workbench selection with react-flow on node
734dfc5 
Bug: #2034
Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jun 9, 2023
@gcoutable @sbegaudeau
[2034] Integrate workbench selection with react-flow on node
0f0e1f4 
Bug: #2034
Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jun 9, 2023
@gcoutable @sbegaudeau
[2034] Integrate workbench selection with react-flow on node
7d63670 
Bug: #2034
Signed-off-by: Guillaume Coutable <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcoutable gcoutable

Labels
difficulty: medium package: diagrams type: feature request
Projects
None yet
Milestone
2023.8.0
Development

Successfully merging a pull request may close this issue.

Integrate the workbench selection with react-flow eclipse-sirius/sirius-web
2 participants
@sbegaudeau @gcoutable