Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border node placement specified with ELK configuration not taken into account anymore #1741

Closed
4 tasks done
AxelRICHARD opened this issue Feb 20, 2023 · 0 comments · Fixed by #1742
Closed
4 tasks done

Border node placement specified with ELK configuration not taken into account anymore #1741

AxelRICHARD opened this issue Feb 20, 2023 · 0 comments · Fixed by #1742
Assignees
@AxelRICHARD
Labels
difficulty: medium package: diagrams type: bug
Milestone
2023.3.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • latest
  • I have specified my environment :
  • All

Steps to reproduce

  1. Create a View with a border node with rectangle style and a label

Expected behavior

The label of the border node is placed according to the ELK configuration (see org.eclipse.sirius.components.diagrams.layout.LayoutConfiguratorRegistry.getDefaultLayoutConfigurator())

Actual behavior

The label of the border node is always placed inside the border node no matter the value of the port label placement property of the ELK configuration.
@AxelRICHARD AxelRICHARD added this to the 2023.3.0 milestone Feb 20, 2023
AxelRICHARD added a commit that referenced this issue Feb 20, 2023
@AxelRICHARD
[1741] Fix ELK border node placement not taken into account anymore
d4b09e3 
Bug: #1741
Signed-off-by: Axel RICHARD <[email protected]>
@AxelRICHARD AxelRICHARD self-assigned this Feb 20, 2023
@AxelRICHARD AxelRICHARD mentioned this issue Feb 20, 2023
Merged
39 tasks
AxelRICHARD added a commit that referenced this issue Feb 20, 2023
@AxelRICHARD
[1741] Fix ELK border node placement not taken into account anymore
10e5a21 
Bug: #1741
Signed-off-by: Axel RICHARD <[email protected]>
@sbegaudeau sbegaudeau linked a pull request Feb 22, 2023 that will close this issue
[1741] Fix ELK border node placement not taken into account anymore #1742
Merged
39 tasks
sbegaudeau pushed a commit that referenced this issue Feb 22, 2023
@AxelRICHARD @sbegaudeau
[1741] Fix ELK border node placement not taken into account anymore
3312e9f 
Bug: #1741
Signed-off-by: Axel RICHARD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2023.3.0
Development

Successfully merging a pull request may close this issue.

[1741] Fix ELK border node placement not taken into account anymore eclipse-sirius/sirius-web
1 participant
@AxelRICHARD