Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the error for strings which are not marked as non-externalized #1517

Closed
sbegaudeau opened this issue Dec 9, 2022 · 0 comments · Fixed by #1530
Closed

Remove the error for strings which are not marked as non-externalized #1517

sbegaudeau opened this issue Dec 9, 2022 · 0 comments · Fixed by #1530
Assignees
@sbegaudeau
Labels
difficulty: starter type: enhancement
Milestone
2023.3.0

Comments

@sbegaudeau
Copy link
Member

It's an Eclipse specific error which does not produce the slightest improvements on our code base and yet is required everywhere. We don't need all those // $NON-NLS$1
@sbegaudeau sbegaudeau added this to the 2023.3.0 milestone Dec 9, 2022
@sbegaudeau sbegaudeau self-assigned this Dec 9, 2022
sbegaudeau added a commit that referenced this issue Dec 14, 2022
@sbegaudeau
[1517] Remove the error for strings which are not marked as non-exter…
8e49c95 
…nalized

Bug: #1517
Signed-off-by: Stéphane Bégaudeau <[email protected]>
@sbegaudeau sbegaudeau mentioned this issue Dec 14, 2022
Merged
39 tasks
@sbegaudeau sbegaudeau linked a pull request Dec 14, 2022 that will close this issue
[1517] Remove the error for strings which are not marked as non-externalized #1530
Merged
39 tasks
sbegaudeau added a commit that referenced this issue Dec 15, 2022
@sbegaudeau
[1517] Remove the error for strings which are not marked as non-exter…
f2b176f 
…nalized

Bug: #1517
Signed-off-by: Stéphane Bégaudeau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbegaudeau sbegaudeau

Labels
difficulty: starter type: enhancement
Projects
None yet
Milestone
2023.3.0
1 participant
@sbegaudeau