Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a tree widget in forms #1139

Closed
sbegaudeau opened this issue Apr 7, 2022 · 0 comments · Fixed by #1158
Closed

Add support for a tree widget in forms #1139

sbegaudeau opened this issue Apr 7, 2022 · 0 comments · Fixed by #1158
Assignees
@pcdavid
Labels
difficulty: medium type: feature request
Milestone
2022.7.0

Comments

@sbegaudeau
Copy link
Member

We need to be able to display trees in form representations. For that, we will rely on the <TreeView />from MaterialUI since the use of the tree representation would be overkill for our need and it would require a large refactoring of the explorer.

We will need to write an ADR showing the necessary GraphQL API for the tree widget in order support the needs of the <TreeView /> along with the Java API of the tree widget description. We may need to discuss the ability (or not) to reuse the existing TreeDescription and Tree GraphQL type.
@sbegaudeau sbegaudeau added this to the 2022.5.0 milestone Apr 7, 2022
@pcdavid pcdavid self-assigned this Apr 12, 2022
pcdavid added a commit that referenced this issue Apr 13, 2022
@pcdavid
[1139] Add ADR for the new tree widget in forms
8ab6b10 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid mentioned this issue Apr 13, 2022
Merged
pcdavid added a commit that referenced this issue Apr 13, 2022
@pcdavid
[1139] Add ADR for the new tree widget in forms
b98d936 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid linked a pull request Apr 13, 2022 that will close this issue
Add support for a tree widget in forms #1158
Merged
pcdavid added a commit that referenced this issue Apr 13, 2022
@pcdavid
[1139] Add ADR for the new tree widget in forms
64bea30 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid pinned this issue Apr 13, 2022
@sbegaudeau sbegaudeau unpinned this issue Apr 18, 2022
@pcdavid pcdavid pinned this issue Apr 19, 2022
@pcdavid pcdavid unpinned this issue Apr 21, 2022
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Add ADR for the new tree widget in forms
1a31a05 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Add GraphQL Schema definitions
7852e02 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Add widget data structure implementation
3d6c2e6 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Add tree description
b5d2f46 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Implement TreeComponent rendering
033288c 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Implement TreePropertySection on the frontend
7d7c6d2 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Hard code a pseudo "semantic browser" in the default rules for…
eb09467 
… testing

Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Implement TreePropertySection on the frontend
7cbcbe3 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Hard code a pseudo "semantic browser" in the default rules for…
6469953 
… testing

Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Implement TreePropertySection on the frontend
c7f4279 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Hard code a pseudo "semantic browser" in the default rules for…
a9aeb7a 
… testing

Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Implement TreePropertySection on the frontend
fc97af3 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Hard code a pseudo "semantic browser" in the default rules for…
bd96862 
… testing

Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Apr 22, 2022
@pcdavid
[1139] Add widget data structure implementation
d21aed5 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Update backend test helpers
182d86c 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Add ADR for the new tree widget in forms
53334f6 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Add GraphQL Schema definitions
6c7bac8 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Add widget data structure implementation
3a78756 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Add tree description
7a0291a 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Implement TreeComponent rendering
1c50d6d 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Implement TreePropertySection on the frontend
dba6a85 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Add frontend tests
d7112f7 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Complete backend test helpers to handle TreeWidget
cf521ee 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 9, 2022
@pcdavid
[1139] Complete backend test helpers to handle TreeWidget
2994093 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 18, 2022
@pcdavid
[1139] Add support for a new tree widget in forms
7c881b6 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid modified the milestones: 2022.5.0, 2022.7.0 May 30, 2022
pcdavid added a commit that referenced this issue May 30, 2022
@pcdavid
[1139] Add support for a new tree widget in forms
8d7ab68 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 30, 2022
@pcdavid
[1139] Add support for a new tree widget in forms
e0a8bb3 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 30, 2022
@pcdavid
[1139] Add support for a new tree widget in forms
625b31a 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 31, 2022
@pcdavid
[1139] Add support for a new tree widget in forms
e4e9a3e 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue May 31, 2022
@pcdavid
[1139] Add support for a new tree widget in forms
b3bf3fc 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Jun 29, 2022
@pcdavid
[1139] Add support for a new tree widget in forms
53cf696 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid added a commit that referenced this issue Jun 30, 2022
@pcdavid
[1139] Add support for a new tree widget in forms
04c46b7 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jul 11, 2022
@pcdavid @sbegaudeau
[1139] Add support for a new tree widget in forms
8b678e0 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jul 20, 2022
@pcdavid @sbegaudeau
[1139] Add support for a new tree widget in forms
d95cf87 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jul 20, 2022
@pcdavid @sbegaudeau
[1139] Add support for a new tree widget in forms
42b96d4 
Bug: #1139
Signed-off-by: Pierre-Charles David <[email protected]>
lfasani added a commit that referenced this issue Sep 12, 2022
@lfasani
[1316][1139] Enhance the view model
6d33e8c 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - SVGNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1139
Signed-off-by: Laurent Fasani <[email protected]>
lfasani added a commit that referenced this issue Sep 19, 2022
@lfasani
[1316][1139] Enhance the view model
334ac0a 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1139
Signed-off-by: Laurent Fasani <[email protected]>
@pcdavid pcdavid mentioned this issue Sep 20, 2022
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium type: feature request
Projects
None yet
Milestone
2022.7.0
Development

Successfully merging a pull request may close this issue.

Add support for a tree widget in forms eclipse-sirius/sirius-web
2 participants
@pcdavid @sbegaudeau