Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The labels of the list items are not layouted properly #1102

Closed
sbegaudeau opened this issue Mar 14, 2022 · 1 comment · Fixed by #1108
Closed

The labels of the list items are not layouted properly #1102

sbegaudeau opened this issue Mar 14, 2022 · 1 comment · Fixed by #1108
Assignees
@lfasani
Labels
difficulty: medium package: diagrams type: bug
Milestone
2022.3.0

Comments

@sbegaudeau
Copy link
Member

sbegaudeau commented Mar 14, 2022 •
edited by lfasani
Loading

The work on labels has created a regression on the label of list items

ELK layout

Capture d’écran 2022-03-14 à 12 06 13

Incremental layout

Capture d’écran 2022-03-14 à 12 06 20

Edit : In fact the issue is more global if we test with node icon. The label of node is also broken

current

image

expected

image
@sbegaudeau sbegaudeau added this to the 2022.03.0 milestone Mar 14, 2022
@sbegaudeau sbegaudeau mentioned this issue Mar 14, 2022
Merged
10 tasks
lfasani added a commit that referenced this issue Mar 15, 2022
@lfasani
[1102] Fix the list item label positioning
f39ac4e 
Add the 'label:inside-begin' label type.
Update the front and the ELK layout

Bug: #1102
Signed-off-by: Laurent Fasani <[email protected]>
@lfasani lfasani mentioned this issue Mar 15, 2022
Merged
5 tasks
@sbegaudeau sbegaudeau changed the title The labels of the list items is not layout properly The labels of the list items is not layouted properly Mar 15, 2022
@sbegaudeau sbegaudeau changed the title The labels of the list items is not layouted properly The labels of the list items are not layouted properly Mar 16, 2022
@sbegaudeau sbegaudeau linked a pull request Mar 16, 2022 that will close this issue
[1102] Fix the list item label positioning #1108
Merged
5 tasks
@sbegaudeau
Copy link
Member Author

Enregistrement.de.l.ecran.2022-03-16.a.10.11.55.mov

It's better for the incremental layout but worse for the ELK layout... Have you tested your solution?

@sbegaudeau sbegaudeau modified the milestones: 2022.3.0, 2022.5.0 Mar 18, 2022
@sbegaudeau sbegaudeau removed this from the 2022.5.0 milestone Mar 22, 2022
lfasani added a commit that referenced this issue Mar 25, 2022
@lfasani
[1102] Fix the node label positioning
20165e0 
Bug: #1102
Signed-off-by: Laurent Fasani <[email protected]>
@sbegaudeau sbegaudeau added this to the 2022.3.0 milestone Mar 28, 2022
sbegaudeau pushed a commit that referenced this issue Mar 28, 2022
@lfasani @sbegaudeau
[1102] Fix the node label positioning
88e4025 
Bug: #1102
Signed-off-by: Laurent Fasani <[email protected]>
sbegaudeau pushed a commit that referenced this issue Mar 28, 2022
@lfasani @sbegaudeau
[1102] Fix the node label positioning
99f13fc 
Bug: #1102
Signed-off-by: Laurent Fasani <[email protected]>
sbegaudeau pushed a commit that referenced this issue Mar 28, 2022
@lfasani @sbegaudeau
[1102] Fix the node label positioning
2eedb48 
Bug: #1102
Signed-off-by: Laurent Fasani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfasani lfasani

Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2022.3.0
Development

Successfully merging a pull request may close this issue.

[1102] Fix the list item label positioning eclipse-sirius/sirius-web
2 participants
@sbegaudeau @lfasani