Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node creation event outside of container bounds forces its resize #1051

Closed
4 tasks done
RaphaelPageObeo opened this issue Feb 9, 2022 · 2 comments · Fixed by #1046
Closed
4 tasks done

Node creation event outside of container bounds forces its resize #1051

RaphaelPageObeo opened this issue Feb 9, 2022 · 2 comments · Fixed by #1046

Comments

@RaphaelPageObeo
Copy link
Contributor

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • latest
  • I have specified my environment :
  • my computer: Windows

Screenshots

before

Steps to reproduce

  • I have two root nodes, A { size: 200x300, position: 10;10 } (in blue) and B { size: 200x300, position: 500;500} (in orange)
  • I click on (100;100) (inside A, red dot) and send a creation event
  • The editing context actually creates the new node in B

Expected behavior

  • A { size: 200x300, position: 10;10 }
  • B { size: 200x300, position: 500;500 }
  • Child { size: 150x70, position: 510;510 }

A is not resized. B is not resized either, since it is big enough to contain the new node. The new node is created in B, since it is a son of B.

Fixed

Actual behavior

  • A { size: 200x300, position: 10;10 }
  • B { size: 600x700, position: 231;231 }
  • Child { size: 150x70, position: 231;231 }

A is not resized. The new node is created in B...but not at the right coordinates, which forces B to be resized

Actual

@gcoutable
Copy link
Member

I don't understand why the click inside A creates a child in B.
Does the child already exist in the model and it is a child of B?

@sbegaudeau
Copy link
Member

sbegaudeau commented Feb 9, 2022

Yes, it's to simulate an operation triggered by a tool on A which creates a child in B. I think I won't surprise you by saying that it was my idea :p

I wanted to challenge a bit our expectation and see how our code would react.

@sbegaudeau sbegaudeau added this to the 2022.03.0 milestone Feb 9, 2022
RaphaelPageObeo added a commit to RaphaelPageObeo/sirius-components that referenced this issue Feb 9, 2022
RaphaelPageObeo added a commit to RaphaelPageObeo/sirius-components that referenced this issue Feb 9, 2022
@sbegaudeau sbegaudeau linked a pull request Feb 11, 2022 that will close this issue
17 tasks
sbegaudeau pushed a commit to RaphaelPageObeo/sirius-components that referenced this issue Feb 11, 2022
sbegaudeau pushed a commit that referenced this issue Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants