Undo Redo Buttons do not react on E4 handlers #977
Comments
N1k145
added a commit
to N1k145/eclipse.platform.ui
that referenced
this issue
Jul 28, 2023
fixes eclipse-platform#977 Undo Redo can now be enabled by E4 Handlers. How To Test: Open the E4UndoRedoTestPart using the Quick Access Check that undo redo is enabled in the menu and tool bar Check that a pop up appears when undo or redo is pressed Switch to a text editor, do the same checks but the behavior should match what you expect from the text editor
N1k145
added a commit
to N1k145/eclipse.platform.ui
that referenced
this issue
Jul 28, 2023
fixes eclipse-platform#977 Undo Redo can now be enabled by E4 Handlers. How To Test: Open the E4UndoRedoTestPart using the Quick Access Check that undo redo is enabled in the menu and tool bar Check that a pop up appears when undo or redo is pressed Switch to a text editor, do the same checks but the behavior should match what you expect from the text editor
N1k145
added a commit
to N1k145/eclipse.platform.ui
that referenced
this issue
Aug 2, 2023
fixes eclipse-platform#977 Undo Redo can now be enabled by E4 Handlers. How To Test: Open the E4UndoRedoTestPart using the Quick Access Check that undo redo is enabled in the menu and tool bar Check that a pop up appears when undo or redo is pressed Switch to a text editor, do the same checks but the behavior should match what you expect from the text editor
N1k145
added a commit
to N1k145/eclipse.platform.ui
that referenced
this issue
Aug 3, 2023
fixes eclipse-platform#977 Undo Redo can now be enabled by E4 Handlers. How To Test: Open the E4UndoRedoTestPart using the Quick Access Check that undo redo is enabled in the menu and tool bar Check that a pop up appears when undo or redo is pressed Switch to a text editor, do the same checks but the behavior should match what you expect from the text editor
N1k145
added a commit
to N1k145/eclipse.platform.ui
that referenced
this issue
Aug 4, 2023
fixes eclipse-platform#977 Undo Redo can now be enabled by E4 Handlers. How To Test: Open the E4UndoRedoTestPart using the Quick Access Check that undo redo is enabled in the menu and tool bar Check that a pop up appears when undo or redo is pressed Switch to a text editor, do the same checks but the behavior should match what you expect from the text editor
BeckerWdf
pushed a commit
that referenced
this issue
Aug 7, 2023
fixes #977 Undo Redo can now be enabled by E4 Handlers. How To Test: Open the E4UndoRedoTestPart using the Quick Access Check that undo redo is enabled in the menu and tool bar Check that a pop up appears when undo or redo is pressed Switch to a text editor, do the same checks but the behavior should match what you expect from the text editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The undo and redo menu actions and toolbar buttons are currently implemented as a RetargetAction and not as a ContributionItem in the WorkbenchActionBuilder.
Copy Past for example are implemented as a ContributionItem.
The RetargetAction can be retargeted inside a E3 world, the ContributionItem supports both E3 and E4.
I would propose to move those to actions to ContributionItems like Copy Past so that they can be changed for an E4 Part that has its own undo redo handler.
The text was updated successfully, but these errors were encountered: