[overlay search] search bar does not forward shortcuts from the editor making it sometimes confusing

[laeubi]

With the new search do the following:

1. Assume you have a document that contains the text "test"
2. Now press CTRL+F and enter "test"
3. Now the editor highlight the first occurrence
4. Now try any usual (e.g. CTRL+X, CTRL+K) shortcuts
5. Nothing happens because text field has focus but it looks like the editor has focus (due to the selection) making the user wondering why it is ignored.

To clarify the behavior was similar than before with the old dialog (except that one has to hit "Find" first) but there it was more obvious where the focus is (e.g. due to the color of the dialog title bar) now with the embedded nature it often tricking me as it is not always clear if the search or the editor has focus, e.g. if I then click into the document the overlay look the same.

It become even more confusing if one use one of the "find icons":

• If one focuses the editor and then press a button, the focus remains there
• If one has previously focused the text field the focus remains there and one can easily accidentally type in new characters while one actually want to type in the editor

I'm not sure what would be the best, but at least I think two things can be improved:

1. Make the overlay look different if it has focus (e.g. maybe a make the border a bit darker and bolder)
2. If one click on the search button the focus should always be on the editor

[HeikoKlare]

Thanks for reporting this! I agree that the shortcut handling is currently not completely consistent or as commonly expected. Actually, making shortcuts of the underlying editor work at all was quite a hack (adapted from the breadcrumb, which does similiar things). There is definitely room for improvement.
I like both proposals for improvement. In particular, the idea of making it visually visible that the overlay has focus is nice and should be rather easy to implement.

This issue is also slightly related to #2509. I have added it to the list in the umbrella issue.

[laeubi]

I also found that often if I search something I probably want to replace it (manually), the workflow is currently a bit error prone

1. Enter a text
2. Text is highlighted
3. Now one needs to carefully click on the tab to focus the editor
4. If one clicks on the editor area the selection is lost

I'm not sure if it would be possible to when focus changes from search overlay to editor if one can preserve the last selection?

[HeikoKlare]

I'm not sure if it would be possible to when focus changes from search overlay to editor if one can preserve the last selection?

Probably this behavior/proposal is a matter of personal preference. In my opinion, the proposed behavior would be unexpected and the current behavior is exactly as expected. If I understand correctly, the current behavior conforms to the behavior of the existing dialog and to the behavior of other tools (like VS code). Or do I miss something?